Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: break out of all loops on first focus #11827

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DPflasterer
Copy link

@DPflasterer DPflasterer commented Apr 26, 2024

I have a form structure like so, where I have a group depth of more than 2.

personal.name.first
personal.name.last
personal.phone-number

What was happening is when iterateFieldsByAction calls itself recursively it did call focus on personal.name.first but then it breaks out of personal.name and continues looping and calling focus on personal.phone-number.

This change will break out of the current loop and recursively break out of all loops.

Copy link

codesandbox bot commented Apr 26, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@DPflasterer DPflasterer changed the title updated iterateFieldsByAction to break out of all loops on first focus break out of all loops on first focus Apr 26, 2024
@DPflasterer DPflasterer changed the title break out of all loops on first focus Fix: break out of all loops on first focus May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant