Matching ChangeHandler type to an actual implementation
#11324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual implementation checks event.type and if it's not a browser event it simply consumes the whole event as a value. Right now I cannot `register` over a custom component with `onChange: (value: string)` as the typing requires my `event` to have a `target: any` property, so primitive values in `onChange` cause a typescript error.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Thank you for your contributions! This Pull Request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Best, RHF Team ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual implementation checks event.type and if it's not a browser event it simply consumes the whole event as a value. Right now I cannot
registerover a custom component withonChange: (value: string)as the typing requires myeventto have atarget: anyproperty, so primitive values inonChangecause a typescript error.