Fix isEmpty check in validateField for custom field components #11179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
rvetere
changed the title
| @@ -67,13 +66,18 @@ export default async <T extends FieldValues>( | |||
| const isRadio = isRadioInput(ref); | |||
| const isCheckBox = isCheckBoxInput(ref); | |||
| const isRadioOrCheckbox = isRadio || isCheckBox; | |||
| const isInputValueEmpty = | |||
| isUndefined(inputValue) || | |||
| inputValue === null || | |||
There was a problem hiding this comment.
so the additional check is just check null?
|
Thank you for your contributions! This Pull Request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Best, RHF Team ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a custom built field component it can happen that the referenced element does not have a value attribute.
But the state is correctly set at the moment of validation.
In that case, the
validateFieldfunction thinks the field is empty, because of this line:I've added a test to show that behavior and it fails with the current implementation as it does in our case of a multi select field with downshift.js
I think we could improve the "is-empty-check" by increasing the priority of the
inputValue- we don't need to check if the ref-element's value attribute is empty when we have a validinputValue, right?