Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add async await to use controller onchange #11165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add async await to use controller onchange #11165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions reports/api-extractor.md
View file
Open in desktop
Expand Up @@ -104,8 +104,8 @@ export type ControllerProps<TFieldValues extends FieldValues = FieldValues, TNam

// @public (undocumented)
export type ControllerRenderProps<TFieldValues extends FieldValues = FieldValues, TName extends FieldPath<TFieldValues> = FieldPath<TFieldValues>> = {
onChange: (...event: any[]) => void;
onBlur: Noop;
onChange: (...event: any[]) => Promise<void | boolean>;
onBlur: () => Promise<void | boolean>;
value: FieldPathValue<TFieldValues, TName>;
disabled?: boolean;
name: TName;
Expand Down
5 changes: 2 additions & 3 deletions src/types/controller.ts
View file
Open in desktop
Expand Up @@ -7,7 +7,6 @@ import {
FieldPath,
FieldPathValue,
FieldValues,
Noop,
RefCallBack,
UseFormStateReturn,
} from './';
Expand All @@ -23,8 +22,8 @@ export type ControllerRenderProps<
TFieldValues extends FieldValues = FieldValues,
TName extends FieldPath<TFieldValues> = FieldPath<TFieldValues>,
> = {
onChange: (...event: any[]) => void;
onBlur: Noop;
onChange: (...event: any[]) => Promise<void | boolean>;
onBlur: () => Promise<void | boolean>;
value: FieldPathValue<TFieldValues, TName>;
disabled?: boolean;
name: TName;
Expand Down
4 changes: 2 additions & 2 deletions src/useController.ts
View file
Open in desktop
Expand Up @@ -131,7 +131,7 @@ export function useController<
? { disabled: formState.disabled || disabled }
: {}),
onChange: React.useCallback(
(event) =>
async (event) =>
_registerProps.current.onChange({
target: {
value: getEventValue(event),
Expand All @@ -142,7 +142,7 @@ export function useController<
[name],
),
onBlur: React.useCallback(
() =>
async () =>
_registerProps.current.onBlur({
target: {
value: get(control._formValues, name),
Expand Down