fix: avoid exception by possible undefined event #11139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Thank you for your contributions! This Pull Request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Best, RHF Team ❤️ |
…op (react-hook-form#11221) * 🐞 fix react-hook-form#11218 useFieldArray focus issue with rules prop * fix issue with not focus
… and field disabled (react-hook-form#11241) * fix(react-hook-form#11239): Set fields disabled state based on form and field disabled prop * fix(react-hook-form#11239): If-check and unit test * Update createFormControl.ts --------- Co-authored-by: Thomas De Bock <thomas.de.bock@persgroep.net> Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
…Standardizing Export, Function Types, and Naming (react-hook-form#11268) * refactor: Matching get and set util conventions - obj => object - set util change arrow function * refactor: change sleep util - change arrow function - change export to export default - The import of the file that uses the function has been modified. * refactor: change deepMerge util - change export to export default - The import of the file that uses the function has been modified. * refactor: api-extractor.md - The changed get function argument is reflected in the report * refactor: change arrow function * Revert "refactor: api-extractor.md" This reverts commit e5ff061. * fix: api-extractor.md build * Revert "fix: api-extractor.md build" This reverts commit d64ec64. * fix: check api-extractor build error
…ate (react-hook-form#11291) * 🐞 fix react-hook-form#11287 disabled prop cause const dirtyFields update * fix issue with test
* add test for disabled form field submit * fix lint --------- Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
…act-hook-form#11294) * fix react-hook-form#11292 issue with controller valdiation prop * remove log
Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
…nknown` (react-hook-form#11333) * fix: DeepPartial type definition * fix: api-extractor build
…hook-form#11353) * 🐛 fix(useController): check if disabled state was set by user Closes: react-hook-form#11320 * ✅ test(useController): disabled state is not overriden if not set Related: react-hook-form#11320 * 🎨 style(useController): format whitespaces * 🐛 fix(useController): set disabled state if passed to controller * ✅ test(useController): should respect disabled state on controller * 🎨 style: run prettier
…1476) * Removed unused utils and resp. test cases * remove unused functions * added removed code --------- Co-authored-by: deep.golani <deep.golani@bfhl.in>
… union type (react-hook-form#11420)" This reverts commit 6fee03c.
* 🤡 fix flush root render hack * fix preitter issue
…e reset mounted field names with keepDirtyValues (react-hook-form#11546)
…k-form#10657) * Add isValidating to field state * Fix type tests for isValidating field state * Adjust bundlewatch maxSize * Fix api-extractor.md merge fail * Adjust formState validatingFields property * Adjust bundlewatch maxSize * Refactoring for isValidating fieldState * Fix multi async validators behavior * Remove unnecessary explicit type definition in isValidating test * Improve _updateIsValidating method * Add proxyFormState check to updateIsValidating method --------- Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
…provided with `reset` api * related react-hook-form#11541 improve dirty check when undefined provided with reset api * early exit when no values provided
* chore: replace ts-ignore with ts-expect-error * chore: replace ts-ignore with ts-expect-error --------- Co-authored-by: deep.golani <deep.golani@bfhl.in>
…eact-hook-form#11613) * 🐞 fix react-hook-form#11590 issue with trigger on validatingFields * fix unit tests and lint error
* 💚 ci(Node): bump node action version * 💚 ci(Issues): bump lock issue action version
react-hook-form#11624) * WIP 🐛 bug(validatingFields, trigger): handle all fields validation trigger * 🔧 chore: update lock file * 🐛 bug(validatingFields, trigger): handle all fields validation trigger * 🔧 chore: remove todo comment * fix react-hook-form#11621 issue with undefined name as field name * fix lint * revert change on trigger --------- Co-authored-by: bill <bluebill1049@hotmail.com>
…form#11723) * fix react-hook-form#11719 validation stuck on true state * fix tests * fix test
Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
…ect (react-hook-form#11831) * fix: correct type of `error` field in `getFieldState` return object * fix: update reports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user fills out a validated form and hits ENTER in the keyboard, the lib throws an exception by undefined event in onChange handler. This PR just verifies if the event exists.