chore: improve error when not passing control to useController
#11028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
MeLlamoPablo
force-pushed
the
missing-control-better-error
branch
from
33ff16b
to
339f925
Compare
MeLlamoPablo
force-pushed
the
missing-control-better-error
branch
from
339f925
to
95e6e4a
Compare
|
Thank you for your contributions! This Pull Request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Best, RHF Team ❤️ |
MeLlamoPablo
force-pushed
the
missing-control-better-error
branch
from
95e6e4a
to
f935f0e
Compare
|
Solved conflicts. This PR is still relevant, bumping to avoid having it auto closed. |
|
Thank you for your contributions! This Pull Request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Best, RHF Team ❤️ |
MeLlamoPablo
force-pushed
the
missing-control-better-error
branch
from
f935f0e
to
fae0f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR improves the message of the error that is generated when you don't pass
controltoControlleroruseController. This error occurs if you neither passcontrolas a prop directly nor providecontrolviaFormProvider.Currently, you would get a rather cryptic "methods is null" error:
After this PR, you get a more informative error:
Interestingly, while the console stack trace is able to pinpoint
useControlleras the source for both errors, Next.js can only understand that this error happens in the code of the library if it's explicitly thrown. Before this PR, Next.js thinks that the error happens in my code.While to most users of the library it should be obvious that you need to somehow pass
controltoController, when developing you can easily get tunnel vision and forget about basic mechanisms, as happened to me. This PR should help developers get back on track without having to spend a lot of time understanding what they did wrong.Type of change
Please delete options that are not relevant.
Checklist: