Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ref.value check #9710

Merged
merged 5 commits into from Jan 3, 2023
Merged

Remove ref.value check #9710

merged 5 commits into from Jan 3, 2023

Conversation

Moshyfawn
Copy link
Member

Closes: #9709

@codesandbox
Copy link

codesandbox bot commented Jan 3, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Size Change: +13 B (0%)

Total Size: 18.7 kB

Filename Size Change
dist/index.cjs.js 9.29 kB +3 B (0%)
dist/index.umd.js 9.39 kB +10 B (0%)

compressed-size-action

@Moshyfawn
Copy link
Member Author

@bluebill1049 I haven't updated the tests yet, since I'm not sure what this change was for, but it breaks the current func of setValue: the ref.value isn't updated

@bluebill1049
Copy link
Member

thanks @Moshyfawn I have fixed the issue, thanks for the patch will release it right away.

@bluebill1049 bluebill1049 merged commit 17fd388 into master Jan 3, 2023
@Moshyfawn Moshyfawn deleted the fix/ref-value branch January 3, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue: calling setValue breaks future onChange calls from a Controller
2 participants