🐞 closes: #9709 remove ref.value check (#9710)

* WIP 🐛fix(Validation): remove ref.value check Closes: #9709 * Update validateField.ts * Update validateField.ts * Update validateField.test.tsx * Update validateField.test.tsx Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
react-hook-form · Jan 3, 2023 · 17fd388 · 17fd388
1 parent 1647bb2
commit 17fd388
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/__tests__/logic/validateField.test.tsx b/src/__tests__/logic/validateField.test.tsx
@@ -36,13 +36,15 @@ describe('validateField', () => {
       },
     });
 
+    const input = document.createElement('input');
+
     expect(
       await validateField(
         {
           _f: {
             mount: true,
             name: 'test',
-            ref: { type: 'text', value: '', name: 'test' },
+            ref: input,
             required: true,
             valueAsNumber: true,
           },
@@ -52,7 +54,7 @@ describe('validateField', () => {
       ),
     ).toEqual({
       test: {
-        ref: { type: 'text', value: '', name: 'test' },
+        ref: input,
         message: '',
         type: 'required',
       },

diff --git a/src/logic/validateField.ts b/src/logic/validateField.ts
@@ -11,6 +11,7 @@ import isCheckBoxInput from '../utils/isCheckBoxInput';
 import isEmptyObject from '../utils/isEmptyObject';
 import isFileInput from '../utils/isFileInput';
 import isFunction from '../utils/isFunction';
+import isHTMLElement from '../utils/isHTMLElement';
 import isMessage from '../utils/isMessage';
 import isNullOrUndefined from '../utils/isNullOrUndefined';
 import isObject from '../utils/isObject';
@@ -65,8 +66,8 @@ export default async <T extends NativeFieldValue>(
     ((valueAsNumber || isFileInput(ref)) &&
       isUndefined(ref.value) &&
       isUndefined(inputValue)) ||
+    (isHTMLElement(ref) && ref.value === '') ||
     inputValue === '' ||
-    ref.value === '' ||
     (Array.isArray(inputValue) && !inputValue.length);
   const appendErrorsCurry = appendErrors.bind(
     null,