🤦🏻‍♂️fix #9661 regression on required valueAsNumber (#9662)

react-hook-form · Dec 24, 2022 · d9b70a8 · d9b70a8
1 parent 508ddc8
commit d9b70a8
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/__tests__/logic/validateField.test.tsx b/src/__tests__/logic/validateField.test.tsx
@@ -36,6 +36,28 @@ describe('validateField', () => {
       },
     });
 
+    expect(
+      await validateField(
+        {
+          _f: {
+            mount: true,
+            name: 'test',
+            ref: { type: 'text', value: '', name: 'test' },
+            required: true,
+            valueAsNumber: true,
+          },
+        },
+        NaN,
+        false,
+      ),
+    ).toEqual({
+      test: {
+        ref: { type: 'text', value: '', name: 'test' },
+        message: '',
+        type: 'required',
+      },
+    });
+
     expect(
       await validateField(
         {

diff --git a/src/logic/validateField.ts b/src/logic/validateField.ts
@@ -66,6 +66,7 @@ export default async <T extends NativeFieldValue>(
       isUndefined(ref.value) &&
       isUndefined(inputValue)) ||
     inputValue === '' ||
+    ref.value === '' ||
     (Array.isArray(inputValue) && !inputValue.length);
   const appendErrorsCurry = appendErrors.bind(
     null,