🐞 fix #9659 NaN prevent validation update (#9660)

react-hook-form · Dec 23, 2022 · 48e1b3c · 48e1b3c
1 parent 0246e8d
commit 48e1b3c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/__tests__/useForm.test.tsx b/src/__tests__/useForm.test.tsx
@@ -751,10 +751,12 @@ describe('useForm', () => {
 
         fireEvent.change(screen.getByRole('textbox'), {
           target: {
-            value: ' ',
+            value: 'test',
           },
         });
 
+        await waitFor(() => screen.getByText('valid'));
+
         fireEvent.change(screen.getByRole('textbox'), {
           target: {
             value: '',

diff --git a/src/logic/createFormControl.ts b/src/logic/createFormControl.ts
@@ -752,17 +752,11 @@ export function createFormControl<
         }
       }
 
-      if (!isPrimitive(fieldValue) || getCurrentFieldValue() === fieldValue) {
-        field._f.deps &&
-          trigger(
-            field._f.deps as
-              | FieldPath<TFieldValues>
-              | FieldPath<TFieldValues>[],
-          );
-        shouldRenderByError(name, isValid, error, fieldState);
-      } else {
-        _updateIsValidating(false);
-      }
+      field._f.deps &&
+        trigger(
+          field._f.deps as FieldPath<TFieldValues> | FieldPath<TFieldValues>[],
+        );
+      shouldRenderByError(name, isValid, error, fieldState);
     }
   };