New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support live editing #750
base: master
Are you sure you want to change the base?
support live editing #750
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bluebill1049/react-hook-form-website/3vDonxyLpG5HwCsRcA9raJjpXsaK |
413507b
to
90523e2
Compare
90523e2
to
1f92b1f
Compare
This is awesome. thanks for putting up the poc, I think we can introduce a button on the top right of that code and show those live update once user clicks on it. |
@bluebill1049 some thoughts:
|
Depend on how much effort would be.
yes, we did consider moving to Nextjs but it's a big effort.
It's probably important to consider mobile as well. |
Not a big effort I think but will improve the DX a lot, and we can benefit from editor's power
On mobile it will change to vertical view, same as here |
Nice 👍 could we add a button here to toggle instead of showing it constantly? as it takes quite a bit of the viewport.
|
Of cause, do we need to keep the CSB button? |
I think we can keep both. Let's remove |
1f92b1f
to
97ebeb4
Compare
@bluebill1049 I think we can defer other todos for future PRs
Don't won't to bloat the bundle size, so we should lazy load those packages, right now I just leave them uneditable
I decided not to support that, we should encourage to use latest version |
97ebeb4
to
84a4d4e
Compare
react-hook-form is a great library and I use it a lot, it would be nice to play with it while reading the doc instead of be navigated to another website, this PR is a POC for that, using react-runner
Preview
TODO:
react-select
react-redux