docs: update readme with browser support #688
Conversation
added browser support to readme. also added .gitattributes type for package-lock
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 2 2
Lines 216 216
Branches 65 65
=======================================
Hits 215 215
Misses 1 1Continue to review full report at Codecov.
|
|
|
||
| | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/edge/edge_48x48.png" alt="IE / Edge" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)</br>IE / Edge | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/firefox/firefox_48x48.png" alt="Firefox" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)</br>Firefox | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/chrome/chrome_48x48.png" alt="Chrome" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)</br>Chrome | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/safari/safari_48x48.png" alt="Safari" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)</br>Safari | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/safari-ios/safari-ios_48x48.png" alt="iOS Safari" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)</br>iOS Safari | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/samsung-internet/samsung-internet_48x48.png" alt="Samsung" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)</br>Samsung | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/opera/opera_48x48.png" alt="Opera" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)</br>Opera | | ||
| | --------- | --------- | --------- | --------- | --------- | --------- | --------- | | ||
| | IE11, Edge| last 2 versions| last 2 versions| last 2 versions| last 2 versions| last 2 versions| last 2 versions |
There was a problem hiding this comment.
If you check caniuse/whatwg (DataTransfer, DataTransferItemList and DataTransferItem), the numbers are a bit different. I think it would be a good idea to have the same numbers as whatwg. And maybe add some links to the APIs.
|
Can we automate this somehow? I wouldn't want to maintain this table when things are going to change. Like, taking this https://github.com/Nyalab/caniuse-api and generating the README update using mrm? |
|
@rxmarbles how's it going with this one? Do you still plan on continuing the work on it? |
|
Hey @rolandjitsu its going. hadn't had a lot of time to tackle it due to work projects. I'll see about trying to get this one knocked out this week 😄 |
|
This issue has been automatically marked as stale because it has not had recent activity in the past 60 days. It will be closed if no further activity occurs. If the problem persists please comment here to bump your issue. Thank You - React Dropzone Maintaners |
|
I'm trying to setup SauceLabs with some basic e2e tests, if it works out, that should give us a list of supported browsers. |
|
@rolandjitsu have you had any luck with the E2Es? I know from experience the emulators can often be a little flakey versus the remote live instances. Also, would it be worth linking to the browser limitations docs underneath the table, for more context on partially supported features in IE11 and Safari? |
|
@thegreatercurve sorry, I've been very busy lately. I have managed to find why tests were not working on SL (some issue with their vms), but I haven't managed to update the PR and add more tests. |
|
This issue has been automatically marked as stale because it has not had recent activity in the past 60 days. It will be closed if no further activity occurs. If the problem persists please comment here to bump your issue. Thank You - React Dropzone Maintaners |
|
Not just yet 😄 |
|
This issue has been automatically marked as stale because it has not had recent activity in the past 60 days. It will be closed if no further activity occurs. If the problem persists please comment here to bump your issue. Thank You - React Dropzone Maintaners |
added browser support to readme. also added .gitattributes type for package-lock
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
adds browser support to readme. solves for #630