Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make sure changes to maxFiles prop are reflected in behaviour #1026

Merged
merged 2 commits into from Oct 30, 2020

Conversation

ath92
Copy link
Contributor

@ath92 ath92 commented Oct 28, 2020

What kind of change does this PR introduce?

  • bugfix
  • feature
  • refactoring / style
  • build / chore
  • documentation

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary
Fix for #1025

Adds maxFiles as a dependency to onDropCb callback, so that changes to maxFiles parameter are reflected in the behaviour of that function.

Does this PR introduce a breaking change?

No
Other information

@coveralls
Copy link

coveralls commented Oct 28, 2020

Pull Request Test Coverage Report for Build 673d1b0344fd15ce9039af0eb38dd592b2618123-PR-1026

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.454%

Totals Coverage Status
Change from base Build b4a1ac66302da2cc952aa93867be091357310414: 0.0%
Covered Lines: 201
Relevant Lines: 201

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 673d1b0344fd15ce9039af0eb38dd592b2618123-PR-1026

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.454%

Totals Coverage Status
Change from base Build b4a1ac66302da2cc952aa93867be091357310414: 0.0%
Covered Lines: 201
Relevant Lines: 201

💛 - Coveralls

@rolandjitsu rolandjitsu merged commit bb42b94 into react-dropzone:master Oct 30, 2020
@github-actions
Copy link

🎉 This PR is included in version 11.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants