bug:change isDragReject true when maxFiles rejectDrag #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build f75389a2e2c95503c910f25fbd75e86b442f8290-PR-1020
💛 - Coveralls |
Pull Request Test Coverage Report for Build 26c7ed2059c3b678c151d05ed9ed4b5a664ad252-PR-1020
💛 - Coveralls |
rxmarbles
requested changes
Oct 20, 2020
Co-authored-by: Rick Markins <rmarkins@gmail.com>
|
I think we're missing some tests, @Morteza-Jenabzadeh could you add some test cases for these changes? |
I have added a test to check isDragReject. |
rolandjitsu
requested changes
Oct 24, 2020
rolandjitsu
approved these changes
Oct 26, 2020
rolandjitsu
requested changes
Oct 26, 2020
…zone into bugfix-isDragReject#1017
…-Jenabzadeh/react-dropzone into bugfix-isDragReject#1017
rolandjitsu
approved these changes
Oct 28, 2020
|
🎉 This PR is included in version 11.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
There is a bug in maxFiles feature that
isDragRejectdoesn't change when DragEvent contains more than the max number of filesThis bug reported #1017
Does this PR introduce a breaking change?
shouldn't
Other information