Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isDragReject should be true if the DragEvent contains more than the max number of files #1017

Closed
1 of 2 tasks
ath92 opened this issue Oct 14, 2020 · 1 comment
Closed
1 of 2 tasks

Comments

@ath92
Copy link
Contributor

ath92 commented Oct 14, 2020

Do you want to request a feature or report a bug?

  • I found a bug
  • I want to propose a feature

What is the current behavior?
When setting the maxFiles prop, if I drag more than that number of files over the dropzone, isDragAccept is true, and isDragReject is false.

If the current behavior is a bug, please provide the steps to reproduce.

  1. Example: https://codesandbox.io/s/stoic-wilbur-3elnq?file=/src/app.js
  2. Try dragging more than 1 file over the dropzone

What is the expected behavior?
isDragReject should be true, i.e. the border should be red in the example

If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information such as the browser version, Operating System and react-dropzone version.
Tested in chrome. Latest version of react-dropzone (11.2.0)

@rolandjitsu
Copy link
Collaborator

rolandjitsu commented Nov 7, 2020

I think this should be fixed now (see #1020). Gonna close it. If there're still issues with this, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants