Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "Invariant Violation: Expected targetIds to be registered." #3409

Merged
merged 3 commits into from Mar 29, 2022
Merged

fix: "Invariant Violation: Expected targetIds to be registered." #3409

merged 3 commits into from Mar 29, 2022

Commits on Mar 22, 2022

  1. fix: "Invariant Violation: Expected targetIds to be registered." 

    We've sporadically seen this error from customers. The call stack
indicates that it's originating from HTML5BackendImpl's
handleTopDragOver's requestAnimationFrame callback.  I've been unable to
reproduce it locally; however, if I simulate a slowdown by replacing
`requestAnimationFrame(callback)` with `setTimeout(callback, 10000)`, I
can fairly reliably reproduce this error.

To fix it, I believe HTML5BackendImpl should consistently clear the
hover animation whenever the drag operation is ended for any reason.

I locally tested this fix in the v15.1.2 tag, and it appeared to work.

Fixes #763, #3403
    @joshkel
    joshkel committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    99db7b8 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. chore: semver

    @darthtrevino
    darthtrevino committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    f8ba3ee View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. fix: cancel any raf before creating a new one

    @darthtrevino
    darthtrevino committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    c901c10 View commit details
    Browse the repository at this point in the history