Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: isBodyOverflowing detection #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improvement: isBodyOverflowing detection #70

wants to merge 1 commit into from

Conversation

shaodahong
Copy link
Member

Resolve #69

@shaodahong
Copy link
Member Author

@yangdongMC 这几天有点忙，不好意思

其实这里改下判断就行了吧，判断下文档的宽度

@coveralls
Copy link

Coverage Status

Coverage remained the same at 23.422% when pulling 9488681 on improve-body-overflow-detection into 40b5bb8 on master.

@zombieJ
Copy link
Member

zombieJ commented Jan 21, 2020

@jljsj33，之前用 && 的目的是啥，这里改成 || 可以不？

ref: 32ba6c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switchScrollingEffect.js 中的isBodyOverflowing方法，在下面一种场景中有点欠缺：
3 participants
@shaodahong @coveralls @zombieJ