Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add isForwardRef & isFragment #463

Closed
wants to merge 0 commits into from

Conversation

li-jia-nan
Copy link
Member

type: replace boolean to WithRef

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
util ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2024 2:42pm

src/ref.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (d760e86) to head (8d3ea41).
Report is 27 commits behind head on master.

❗ Current head 8d3ea41 differs from pull request most recent head 3293f24. Consider uploading reports for the commit 3293f24 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   91.65%   91.67%   +0.01%     
==========================================
  Files          38       38              
  Lines         911      913       +2     
  Branches      291      283       -8     
==========================================
+ Hits          835      837       +2     
  Misses         74       74              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan changed the title type: replace boolean to WithRef chore: add isForwardRef & isFragment Sep 21, 2023
@MadCcc
Copy link
Member

MadCcc commented Sep 21, 2023

要解决什么问题?

@li-jia-nan
Copy link
Member Author

要解决什么问题?

没发现问题,只是读这块代码的时候觉得可以优化一下,所以加了两个判断

src/ref.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants