fix: useMobile should not warn useLayoutEffect in SSR

react-component · Mar 29, 2023 · a43a24c · a43a24c
1 parent 2410781
commit a43a24c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/hooks/useMobile.ts b/src/hooks/useMobile.ts
@@ -1,5 +1,6 @@
-import { useLayoutEffect, useState } from 'react';
+import { useState } from 'react';
 import isMobile from '../isMobile';
+import useLayoutEffect from './useLayoutEffect';
 
 /**
  * Hook to detect if the user is on a mobile device

diff --git a/tests/hooks.test.js b/tests/hooks.test.js
@@ -518,5 +518,18 @@ describe('hooks', () => {
 
       navigatorSpy.mockRestore();
     });
+
+    it('should not warn useLayoutEffect in SSR', () => {
+      const errorSpy = jest.spyOn(console, 'error');
+      const Demo = () => {
+        useMobile();
+        return null;
+      };
+      renderToString(<Demo />);
+      expect(errorSpy).not.toHaveBeenCalledWith(
+        expect.stringContaining('useLayoutEffect'),
+        expect.anything(),
+      );
+    });
   });
 });