chore: use father #268

xrkffgg · 2020-08-21T03:10:51Z

No description provided.

vercel · 2020-08-21T03:10:54Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/upload/5oh00dkmo
✅ Preview: https://upload-git-up-father.react-component.vercel.app

lgtm-com · 2020-08-21T03:14:57Z

This pull request introduces 2 alerts and fixes 2 when merging 5da11b7 into 472a3d6 - view on LGTM.com

new alerts:

2 for Hard-coded credentials

fixed alerts:

2 for Hard-coded credentials

lgtm-com · 2020-08-21T03:28:09Z

This pull request introduces 2 alerts and fixes 2 when merging e9eaa8e into 472a3d6 - view on LGTM.com

new alerts:

2 for Hard-coded credentials

fixed alerts:

2 for Hard-coded credentials

zombieJ · 2020-08-21T08:13:31Z

@kermit-xuan could you help to review?

kerm1it · 2020-08-21T08:54:06Z

@xrkffgg please install it.

package.json

kerm1it · 2020-08-21T10:00:03Z

@zombieJ 是不是考虑加个 compile 的 CI 检查？就和 antd 的一样

zombieJ · 2020-08-22T01:47:46Z

@zombieJ 是不是考虑加个 compile 的 CI 检查？就和 antd 的一样

需要的，迁移 father 都要加一个~

lgtm-com · 2020-08-24T02:30:43Z

This pull request introduces 2 alerts and fixes 2 when merging f018c70 into 472a3d6 - view on LGTM.com

new alerts:

2 for Hard-coded credentials

fixed alerts:

2 for Hard-coded credentials

xrkffgg · 2020-08-24T02:47:42Z

@kermit-xuan PTAL

kerm1it · 2020-08-24T02:52:19Z

可以在 CI 的 lint 后面加个 compile 的检查么？防止编译出错

.travis.yml

lgtm-com · 2020-08-24T03:01:21Z

This pull request introduces 2 alerts and fixes 2 when merging 8eb6da1 into 472a3d6 - view on LGTM.com

new alerts:

2 for Hard-coded credentials

fixed alerts:

2 for Hard-coded credentials

kerm1it

测试不需要改造的话，我感觉OK了。

afc163 · 2020-08-24T03:20:11Z

examples/customRequest.tsx

 import axios from 'axios';
+import Upload from '../src/index';


Suggested change

import Upload from '../src/index';

import Upload from '..';

afc163 · 2020-08-24T03:22:03Z

覆盖率的 ci 是不是没生效。

kerm1it · 2020-08-24T03:27:19Z

运行了，但是好像没有打印出来。

.travis.yml

lgtm-com · 2020-08-24T03:49:07Z

This pull request introduces 2 alerts and fixes 2 when merging 972147f into 472a3d6 - view on LGTM.com

new alerts:

2 for Hard-coded credentials

fixed alerts:

2 for Hard-coded credentials

lgtm-com · 2020-08-24T03:55:56Z

This pull request introduces 2 alerts and fixes 2 when merging 225ce2b into 472a3d6 - view on LGTM.com

new alerts:

2 for Hard-coded credentials

fixed alerts:

2 for Hard-coded credentials

lgtm-com · 2020-08-29T14:47:37Z

This pull request introduces 1 alert and fixes 3 when merging d32f18b into bb07467 - view on LGTM.com

new alerts:

1 for Useless conditional

fixed alerts:

2 for Hard-coded credentials
1 for Useless conditional

kerm1it · 2020-08-29T15:00:34Z

应该差不多了，review 的时候最好在本地编辑器看，改动有点大（类型定义）。

zombieJ · 2020-08-31T02:20:42Z

src/index.ts

@@ -1,4 +1,3 @@
-// export this package's api
 import Upload from './Upload';


多加一个 UploadProps export.

zombieJ · 2020-08-31T02:41:00Z

src/AjaxUploader.tsx

-    },
-    {},
-  );
+const dataOrAriaAttributeProps = (props: React.AriaAttributes | React.DataHTMLAttributes<any>) => {


等一下这个：react-component/util#142

done:

+ rc-util@5.2.0

pickerAttrs(props, { aria: true, data: true });

这个是改啥了？

就是直接用 rc-util 里面的 pickerAttrs，这个方法可以删掉了。

这个怎么用呢？😂

zombieJ · 2020-08-31T02:42:15Z

src/AjaxUploader.tsx


  componentDidMount() {
    this._isMounted = true;
  }

  componentWillUnmount() {
    this._isMounted = false;
-    this.abort();
+    this.abort('');


~~是不是可以 this.abort(null)?~~

下面的 abort 定义让 file 变成 optional 的即可~

kerm1it · 2020-08-31T02:47:31Z

我在考虑要不要加个 RCFile 的定义? 不然用到 uid 属性的地方就都得变成any。

lgtm-com · 2020-08-31T02:54:56Z

This pull request introduces 1 alert and fixes 3 when merging 1e515ba into bb07467 - view on LGTM.com

new alerts:

1 for Useless conditional

fixed alerts:

2 for Hard-coded credentials
1 for Useless conditional

zombieJ · 2020-08-31T02:56:33Z

我在考虑要不要加个 RCFile 的定义? 不然用到 uid 属性的地方就都得变成any。

👍 的确 any 有点蛋疼

lgtm-com · 2020-08-31T03:17:29Z

This pull request introduces 1 alert and fixes 3 when merging ef2ebbc into bb07467 - view on LGTM.com

new alerts:

1 for Useless conditional

fixed alerts:

2 for Hard-coded credentials
1 for Useless conditional

lgtm-com · 2020-08-31T03:29:35Z

This pull request introduces 1 alert and fixes 3 when merging cfcf2d2 into bb07467 - view on LGTM.com

new alerts:

1 for Useless conditional

fixed alerts:

2 for Hard-coded credentials
1 for Useless conditional

lgtm-com · 2020-08-31T03:33:22Z

This pull request fixes 3 alerts when merging a58f859 into bb07467 - view on LGTM.com

fixed alerts:

2 for Hard-coded credentials
1 for Useless conditional

lgtm-com · 2020-08-31T03:52:57Z

This pull request fixes 3 alerts when merging b8538d6 into bb07467 - view on LGTM.com

fixed alerts:

2 for Hard-coded credentials
1 for Useless conditional

xrkffgg requested review from afc163 and zombieJ August 21, 2020 03:11

vercel bot deployed to Preview August 21, 2020 03:20 View deployment

kerm1it reviewed Aug 21, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

vercel bot deployed to Preview August 24, 2020 02:26 View deployment

vercel bot temporarily deployed to Preview August 24, 2020 02:54 Inactive

vercel bot deployed to Preview August 24, 2020 02:55 View deployment

xrkffgg commented Aug 24, 2020

View reviewed changes

.travis.yml Show resolved Hide resolved

kerm1it approved these changes Aug 24, 2020

View reviewed changes

afc163 reviewed Aug 24, 2020

View reviewed changes

.travis.yml Show resolved Hide resolved

vercel bot deployed to Preview August 24, 2020 03:45 View deployment

vercel bot temporarily deployed to Preview August 24, 2020 03:50 Inactive

vercel bot deployed to Preview August 24, 2020 03:52 View deployment

xrkffgg force-pushed the up-father branch from 225ce2b to 7c5735d Compare August 24, 2020 04:31

xrkffgg changed the title ~~[WIP] chore: use father~~ chore: use father Aug 30, 2020

zombieJ reviewed Aug 31, 2020

View reviewed changes

src/index.ts

@@ -1,4 +1,3 @@

// export this package's api

import Upload from './Upload';

Copy link

Member

zombieJ Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多加一个 UploadProps export.

zombieJ approved these changes Aug 31, 2020

View reviewed changes

add UploadProps export

1e515ba

vercel bot deployed to Preview August 31, 2020 02:38 View deployment

zombieJ reviewed Aug 31, 2020

View reviewed changes

RCFile & pickAttrs

ef2ebbc

vercel bot deployed to Preview August 31, 2020 03:14 View deployment

fix lint

cfcf2d2

vercel bot deployed to Preview August 31, 2020 03:25 View deployment

fix alert

a58f859

vercel bot deployed to Preview August 31, 2020 03:29 View deployment

fix: types of upload

b8538d6

vercel bot deployed to Preview August 31, 2020 03:48 View deployment

afc163 merged commit 7822c25 into master Aug 31, 2020

afc163 deleted the up-father branch August 31, 2020 06:25

afc163 mentioned this pull request Aug 31, 2020

perf: 🆙 upgrade rc-dialog and rc-upload and rc-progress ant-design/ant-design#26494

Merged

22 tasks

zombieJ mentioned this pull request Jan 11, 2021

请问一下最新版4.10.0里Upload的interface改动是否正确 ant-design/ant-design#28744

Closed

1 task

This was referenced Mar 12, 2021

chore(deps): bump rc-upload from 3.2.1 to 4.1.0 bencallaway/ant-design#22

Closed

chore(deps): bump rc-upload from 3.2.1 to 4.1.0 huahuaQAQ/ant-design#24

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: use father #268

chore: use father #268

xrkffgg commented Aug 21, 2020

vercel bot commented Aug 21, 2020 •

edited

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 21, 2020

zombieJ commented Aug 21, 2020

kerm1it commented Aug 21, 2020

kerm1it commented Aug 21, 2020 •

edited

zombieJ commented Aug 22, 2020

lgtm-com bot commented Aug 24, 2020

xrkffgg commented Aug 24, 2020

kerm1it commented Aug 24, 2020

lgtm-com bot commented Aug 24, 2020

kerm1it left a comment

afc163 Aug 24, 2020 •

edited

afc163 commented Aug 24, 2020

kerm1it commented Aug 24, 2020

lgtm-com bot commented Aug 24, 2020

lgtm-com bot commented Aug 24, 2020

lgtm-com bot commented Aug 29, 2020

kerm1it commented Aug 29, 2020 •

edited

zombieJ Aug 31, 2020

zombieJ Aug 31, 2020

zombieJ Aug 31, 2020

xrkffgg Aug 31, 2020

kerm1it Aug 31, 2020

xrkffgg Aug 31, 2020

zombieJ Aug 31, 2020 •

edited

kerm1it commented Aug 31, 2020 •

edited

lgtm-com bot commented Aug 31, 2020

zombieJ commented Aug 31, 2020

lgtm-com bot commented Aug 31, 2020

lgtm-com bot commented Aug 31, 2020

lgtm-com bot commented Aug 31, 2020

lgtm-com bot commented Aug 31, 2020

		import axios from 'axios';
		import Upload from '../src/index';

		@@ -1,4 +1,3 @@
		// export this package's api
		import Upload from './Upload';

chore: use father #268

chore: use father #268

Conversation

xrkffgg commented Aug 21, 2020

vercel bot commented Aug 21, 2020 • edited

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 21, 2020

zombieJ commented Aug 21, 2020

kerm1it commented Aug 21, 2020

kerm1it commented Aug 21, 2020 • edited

zombieJ commented Aug 22, 2020

lgtm-com bot commented Aug 24, 2020

xrkffgg commented Aug 24, 2020

kerm1it commented Aug 24, 2020

lgtm-com bot commented Aug 24, 2020

kerm1it left a comment

Choose a reason for hiding this comment

afc163 Aug 24, 2020 • edited

Choose a reason for hiding this comment

afc163 commented Aug 24, 2020

kerm1it commented Aug 24, 2020

lgtm-com bot commented Aug 24, 2020

lgtm-com bot commented Aug 24, 2020

lgtm-com bot commented Aug 29, 2020

kerm1it commented Aug 29, 2020 • edited

zombieJ Aug 31, 2020

Choose a reason for hiding this comment

zombieJ Aug 31, 2020

Choose a reason for hiding this comment

zombieJ Aug 31, 2020

Choose a reason for hiding this comment

xrkffgg Aug 31, 2020

Choose a reason for hiding this comment

kerm1it Aug 31, 2020

Choose a reason for hiding this comment

xrkffgg Aug 31, 2020

Choose a reason for hiding this comment

zombieJ Aug 31, 2020 • edited

Choose a reason for hiding this comment

kerm1it commented Aug 31, 2020 • edited

lgtm-com bot commented Aug 31, 2020

zombieJ commented Aug 31, 2020

lgtm-com bot commented Aug 31, 2020

lgtm-com bot commented Aug 31, 2020

lgtm-com bot commented Aug 31, 2020

lgtm-com bot commented Aug 31, 2020

vercel bot commented Aug 21, 2020 •

edited

kerm1it commented Aug 21, 2020 •

edited

afc163 Aug 24, 2020 •

edited

kerm1it commented Aug 29, 2020 •

edited

zombieJ Aug 31, 2020 •

edited

kerm1it commented Aug 31, 2020 •

edited