Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cut logic of measure #437

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: cut logic of measure #437

merged 1 commit into from
Nov 13, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 13, 2023

当 Popup 贴底做测量统计时,如果 Popup 有元素是超出 Popup 宽高的会导致游览器出现滚动条。而当回复原来位置后,滚动条消失导致偏了一个滚动条的尺寸。

ref ant-design/ant-design#45784

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #437 (93ea11b) into master (cf6ec04) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 93ea11b differs from pull request most recent head 900c03f. Consider uploading reports for the commit 900c03f to get more accurate results

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   97.73%   97.74%   +0.01%     
==========================================
  Files          13       13              
  Lines         794      798       +4     
  Branches      224      224              
==========================================
+ Hits          776      780       +4     
  Misses         18       18              
Files Coverage Δ
src/hooks/useAlign.ts 97.70% <100.00%> (+0.03%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@zombieJ zombieJ merged commit 337ff4e into master Nov 13, 2023
7 checks passed
@zombieJ zombieJ deleted the cut branch November 13, 2023 06:35
@@ -672,6 +675,8 @@ export default function useAlign(
const offsetY4Bottom =
popupMirrorRect.bottom - popupRect.y - (nextOffsetY + popupRect.height);

debugger;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stupid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant