Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(onBlur): 移除 onBlur 时添加 option 以及收起面板等默认行为 #953

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(onBlur): 移除 onBlur 时添加 option 以及收起面板等默认行为 #953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bdb671
feat(onBlur): remove custom behavior
vaynevayne Jun 12, 2023
d8792b7
fix(baseSelect): blur 时清空值即autoClearSearchValue
vaynevayne Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 4 additions & 14 deletions src/BaseSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,11 +381,14 @@ const BaseSelect = React.forwardRef((props: BaseSelectProps, ref: React.Ref<Base
setInnerOpen(nextOpen);

if (mergedOpen !== nextOpen) {
if (!nextOpen) {
onSearch('', { source: 'blur' });
}
onDropdownVisibleChange?.(nextOpen);
}
}
},
[disabled, mergedOpen, setInnerOpen, onDropdownVisibleChange],
[mergedOpen, disabled, setInnerOpen, onDropdownVisibleChange, onSearch],
);

// ============================= Search =============================
Expand Down Expand Up @@ -563,25 +566,12 @@ const BaseSelect = React.forwardRef((props: BaseSelectProps, ref: React.Ref<Base
const onContainerBlur: React.FocusEventHandler<HTMLElement> = (...args) => {
setMockFocused(false, () => {
focusRef.current = false;
onToggleOpen(false);
});

if (disabled) {
return;
}

if (mergedSearchValue) {
// `tags` mode should move `searchValue` into values
if (mode === 'tags') {
onSearch(mergedSearchValue, { source: 'submit' });
} else if (mode === 'multiple') {
// `multiple` mode only clean the search value but not trigger event
onSearch('', {
source: 'blur',
});
}
}

if (onBlur) {
onBlur(...args);
}
Expand Down