Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: groupLabel feat and test error #942

Merged
merged 4 commits into from May 19, 2023
Merged

fix: groupLabel feat and test error #942

merged 4 commits into from May 19, 2023

Conversation

BoyYangzai
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
select ❌ Failed (Inspect) May 19, 2023 7:36am

@codecov
Copy link

codecov bot commented May 19, 2023 •
edited

Codecov Report

Merging #942 (336afe7) into master (114b045) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 336afe7 differs from pull request most recent head 8b7e562. Consider uploading reports for the commit 8b7e562 to get more accurate results

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files          37       37              
  Lines        1353     1352       -1     
  Branches      366      365       -1     
==========================================
- Hits         1348     1347       -1     
  Misses          4        4              
  Partials        1        1
Impacted Files Coverage Δ
src/utils/valueUtil.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BoyYangzai BoyYangzai mentioned this pull request May 19, 2023
Merged
20 tasks
Wxh16144
Wxh16144 reviewed May 19, 2023
View reviewed changes
tests/Select.test.tsx
options={genOpts('noGroupLabel')}
fieldNames={{ value: 'data', label: 'noGroupLabel' }}
/>,
<Select options={genOpts('label', 'label')} open />,
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提一个意见, 这里的快照测试, 直接 match container 估计有点问题, 建议可以先把 palen select 出来去再去 match.

expect(document.querySelector('.rc-virtual-list')).toMatchSnapshot();

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前冲快照信息有点难得到有哪些改动🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done✅

MadCcc
MadCcc reviewed May 19, 2023
View reviewed changes
src/utils/valueUtil.ts Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented May 19, 2023

这个 vercel 的 ci 谁来修一下，各个 PR 都是 ❌。。

@Wxh16144
Copy link

这个 vercel 的 ci 谁来修一下，各个 PR 都是 ❌。。

改用 surge 吗?

@MadCcc
Copy link
Member

MadCcc commented May 19, 2023

这个 vercel 的 ci 谁来修一下，各个 PR 都是 ❌。。

改用 surge 吗?

升级一下 dumi2 就行了

@MadCcc MadCcc merged commit d98542a into react-component:master May 19, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wxh16144 Wxh16144 Wxh16144 left review comments

@MadCcc MadCcc MadCcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BoyYangzai @afc163 @Wxh16144 @MadCcc