feat: add groupLabel FieldName #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BoyYangzai
commented
May 16, 2023
BoyYangzai
commented
- fix [select] 开启OptGroup ，并自定义fieldNames时，分组label不显示 ant-design/ant-design#42328
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zombieJ
reviewed
May 16, 2023
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 37 37
Lines 1352 1353 +1
Branches 381 366 -15
=======================================
+ Hits 1347 1348 +1
Misses 4 4
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zombieJ
reviewed
May 17, 2023
zombieJ
reviewed
May 17, 2023
MadCcc
reviewed
May 17, 2023
src/utils/valueUtil.ts
Outdated
Comment on lines
55
to
60
| let label; | ||
| if (isGroupOption) { | ||
| label = data[groupLabel] | ||
| } else { | ||
| label = data[fieldLabel] | ||
| } |
There was a problem hiding this comment.
Suggested change
| let label; | |
| if (isGroupOption) { | |
| label = data[groupLabel] | |
| } else { | |
| label = data[fieldLabel] | |
| } | |
| const label = isGroupOption ? data[groupLabel] : data[fieldLabel]; |
There was a problem hiding this comment.
Suggested change
| let label; | |
| if (isGroupOption) { | |
| label = data[groupLabel] | |
| } else { | |
| label = data[fieldLabel] | |
| } | |
| const label = data[isGroupOption ? groupLabel : fieldLabel]; |
afc163
reviewed
May 17, 2023
zombieJ
reviewed
May 17, 2023
MadCcc
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.