Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add List ScrollBar direction #940

Merged
merged 4 commits into from May 18, 2023

Conversation

@vercel
Copy link

vercel bot commented May 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
select ❌ Failed (Inspect) May 18, 2023 3:50am

@BoyYangzai
Copy link
Contributor Author

test等待该pr合并升级

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #940 (6232bc9) into master (0c8db0c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6232bc9 differs from pull request most recent head fadd395. Consider uploading reports for the commit fadd395 to get more accurate results

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          37       37           
  Lines        1352     1353    +1     
  Branches      381      366   -15     
=======================================
+ Hits         1347     1348    +1     
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/OptionList.tsx 99.33% <ø> (ø)
src/SelectContext.ts 100.00% <ø> (ø)
src/Select.tsx 100.00% <100.00%> (ø)
src/utils/valueUtil.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yoyo837
Copy link
Member

yoyo837 commented May 16, 2023

搞完给tr-tree也升级 rc-virtual-list

@yoyo837
Copy link
Member

yoyo837 commented May 16, 2023

这里是否考虑也添加测试用例覆盖一下?

tests/Select.test.tsx Outdated Show resolved Hide resolved
@zombieJ zombieJ merged commit af6fcda into react-component:master May 18, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong scroll position in Select drop down list in rtl (right to left)
3 participants