antd v5: Controlled components will treat null as empty value and null can not be used as an option value.
#777
Conversation
… umi-utils is 1.x, which can't deal with ts import type
…ve null instead of undefined value
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return values; | ||
| }, [internalValue, convert2LabelValues, mode]); | ||
|
|
||
| // Fill label with cache to avoid option remove | ||
| const [mergedValues, getMixedOption] = useCache(rawLabeledValues, valueOptions); | ||
|
|
||
| const displayValues = React.useMemo(() => { | ||
| // `null` need show as placeholder instead |
There was a problem hiding this comment.
Since when null as value will returns [], this logic code is no looger needed. When value={null}, the placeholder will show up correctly.
因为 null 作为空值已经做了返回 [] 的处理，所以这段特殊处理此 issue 的逻辑已经不需要了，value={null} 时 placeholder 会正确显示。
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
=======================================
Coverage 99.50% 99.51%
=======================================
Files 25 25
Lines 1020 1029 +9
Branches 341 337 -4
=======================================
+ Hits 1015 1024 +9
Misses 4 4
Partials 1 1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
先到 FAQ 里 PR 一下，说明一下 null 值在 antd 中的定义，以及为什么要这么做哈~ |
|
这是 break change，至少 4.x 中不能改。 |
|
嗯嗯，这应该是 |
shezhangzhang
changed the title
null as empty value and null can not be used as an option value.null as empty value and null can not be used as an option value.
Changes:
nullcannot be used as an option value.allowCleartriggerChange will pass thenullto onChange() instead ofundefined.null-controlledexample. (placeholder will show up)nullas an option value.prettierlatest (2.x) version to devDependencies, because the current prettier version added by umi-utils is 1.x, which can't deal with typescirpt import type syntax (prettier 1.x error: SyntaxError: '=' expected).nullvalue wanrning (/utils/warningPropsUtils.ts).Chinese (中文)：
null不能作为选项的 value 了。allowClear触发清空更新会传递null作为空值而不是undefined。null作为 value 初始值的例子（占位符会正确出现，移除了之前的特殊处理逻辑）。null不能作为 value 相关的几个测试用例。prettier的最新版本（2.x）到 devDependencies，因为当前由 umi-utils 安装的的 prettier 版本是 1.x, 不能正确处理 typescript 的 import type 语法（prettier 1.x 会报错：SyntaxError: '=' expected）。null作为 value 出现在 options 中的告警（在 /utils/warningPropsUtils.ts 中）。