Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better select types #714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claudiocro
Copy link

@claudiocro claudiocro commented Jan 26, 2022

This is introducing a breaking typescript change for this two options:

  • optionFilterProp
  • optionLabelProp

they are now checking against OptionType to make sure the property is a valid one.

@vercel
Copy link

vercel bot commented Jan 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/5hTfSjycYL6YrdYVXEMCQ383q6Gm
✅ Preview: https://select-git-fork-claudiocro-f-select-opti-d023c7-react-component.vercel.app

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #714 (7a3289f) into master (f7ed85e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          25       25           
  Lines        1009     1009           
  Branches      334      334           
=======================================
  Hits         1004     1004           
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/Select.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ed85e...7a3289f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant