fix: Options with same key (#555)

react-component · Oct 8, 2020 · 9edfb76 · 9edfb76 · vercel · Oct 8, 2020
1 parent a4d44d4
commit 9edfb76
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/utils/valueUtil.ts b/src/utils/valueUtil.ts
@@ -197,7 +197,7 @@ export function filterOptions(
   let filterFunc: FilterFunc<SelectOptionsType[number]>;
 
   if (filterOption === false) {
-    return options;
+    return [...options];
   }
   if (typeof filterOption === 'function') {
     filterFunc = filterOption;

diff --git a/tests/Tags.test.tsx b/tests/Tags.test.tsx
@@ -386,4 +386,17 @@ describe('Select.Tags', () => {
       expect(findSelection(wrapper).text()).toEqual('f');
     });
   });
+
+  it('not modify origin options', () => {
+    const errSpy = jest.spyOn(console, 'error');
+    const wrapper = mount(<Select mode="tags" filterOption={false} options={[]} />);
+    toggleOpen(wrapper);
+    wrapper.find('input').simulate('change', { target: { value: 'a' } });
+    wrapper.find('input').simulate('change', { target: { value: 'ab' } });
+    wrapper.find('input').simulate('change', { target: { value: 'a' } });
+    wrapper.find('input').simulate('change', { target: { value: '' } });
+
+    expect(errSpy).not.toHaveBeenCalled();
+    errSpy.mockRestore();
+  });
 });