Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate component accept onMouseEnter and onMouseLeave event #127

Merged
merged 12 commits into from
May 27, 2023

Conversation

XuChunxiao
Copy link
Contributor

@XuChunxiao XuChunxiao commented Jun 10, 2021

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #127 (28e14c3) into master (fc281a9) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 28e14c3 differs from pull request most recent head f0cce76. Consider uploading reports for the commit f0cce76 to get more accurate results

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   97.02%   97.19%   +0.16%     
==========================================
  Files           4        4              
  Lines         168      178      +10     
  Branches       51       56       +5     
==========================================
+ Hits          163      173      +10     
  Misses          5        5              
Impacted Files Coverage Δ
src/Rate.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel
Copy link

vercel bot commented May 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rate ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2023 2:34pm

tests/simple.spec.js Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented May 27, 2023

Working on it.

src/Rate.tsx Outdated Show resolved Hide resolved
tests/simple.spec.js Outdated Show resolved Hide resolved
tests/simple.spec.js Outdated Show resolved Hide resolved
tests/simple.spec.js Outdated Show resolved Hide resolved
tests/simple.spec.js Outdated Show resolved Hide resolved
@afc163 afc163 merged commit 6b49fae into react-component:master May 27, 2023
7 of 8 checks passed
Comment on lines +74 to +87
const dataOrAriaAttributeProps = Object.keys(restProps).reduce(
(prev, key) => {
if (
key.substr(0, 5) === 'data-' ||
key.substr(0, 5) === 'aria-' ||
key === 'role'
) {
// eslint-disable-next-line no-param-reassign
prev[key] = restProps[key];
}
return prev;
},
{},
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants