chore: use father #85

xrkffgg · 2020-08-27T10:01:09Z

No description provided.

vercel · 2020-08-27T10:01:12Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/progress/kryv8374w
✅ Preview: https://progress-git-up-father.react-component.vercel.app

afc163 · 2020-08-31T09:19:17Z

package.json

+    "rc-tools": "9.x",
+    "react": "^16.9.0",
+    "react-dom": "^16.9.0",
+    "typescript": "^3.9.7"


xrkffgg · 2020-08-31T09:28:40Z

PR 的过去了，push 的一直报错。

zombieJ · 2020-08-31T09:47:06Z

https://stackoverflow.com/questions/34974925/travis-ci-creates-two-builds-for-each-github-commit-push/34975730

PR 是合到 master 后的 CI， Push 是当前 branch 的 CI。本地 git clean -fdx 重新安装一遍试试看会不会遇到这个错误。

afc163 · 2020-08-31T09:47:12Z

package.json

+    "eslint": "^7.6.0",
+    "father": "^2.29.6",
+    "np": "^6.5.0",
+    "rc-tools": "9.x",


rc-tools 应该没用了。

codecov · 2020-08-31T13:14:38Z

Codecov Report

Merging #85 into master will increase coverage by 14.37%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #85       +/-   ##
===========================================
+ Coverage   84.68%   99.05%   +14.37%     
===========================================
  Files           4        3        -1     
  Lines         111      106        -5     
  Branches       24       26        +2     
===========================================
+ Hits           94      105       +11     
+ Misses         17        1       -16

Impacted Files	Coverage Δ
src/Circle.tsx	`100.00% <100.00%> (ø)`
src/Line.tsx	`100.00% <100.00%> (ø)`
src/common.ts	`94.73% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d693d8...8205255. Read the comment docs.

afc163 · 2020-08-31T13:17:08Z

.travis.yml


 node_js:
- 10
+- 12


升级了就好了。

现在就剩下覆盖率的问题了。

用例转了下写法就下降了。。。

可以补两个用例

之前的dialog 和 upload 咋没有覆盖率检查结果显示呢？

版本的原因吧，那2个都是10

zombieJ · 2020-08-31T15:31:06Z

index.js

@@ -1,4 +1,4 @@
-import Progress, {  Line, Circle } from './src/';
+import Progress, { Line, Circle } from './src';


这个文件应该没用了

kerm1it · 2020-09-01T04:20:49Z

src/interface.ts

@@ -0,0 +1,22 @@
+import * as React from 'react';
+
+export interface progressProps {


类型定义以大写开头

xrkffgg · 2020-09-01T06:55:41Z

@kermit-xuan 帮忙 Review 下~

kerm1it · 2020-09-01T10:23:59Z

src/Circle.tsx

@@ -2,18 +2,26 @@
 import React, { useMemo } from 'react';


导入 React 的时候最好使用 import * as React from 'React'，否则当 tsconfig 未开启 esModuleInterop 选项时，编译会有问题。

see ant-design/ant-design#26484

kerm1it · 2020-09-01T10:24:52Z

src/Circle.tsx

  return +percent.replace('%', '');
 }

-function toArray(symArray) {
+function toArray(symArray: any) {


这里有具体类型的话，尽量写上类型，避免使用 any

toArray 一个传入 percent?: number | number[];
一个传入 string | string[] | object;
然后下面还用这个的返回值
😂 索性就改成 any 了

kerm1it · 2020-09-01T10:25:45Z

src/Circle.tsx

@@ -57,7 +65,7 @@ function getPathStyles(offset, percent, strokeColor, strokeWidth, gapDegree = 0,
  };
 }

-const Circle = ({
+const Circle: React.FC<ProgressProps> = ({


函数式组件导出时，写上 displayName 属性。

kerm1it · 2020-09-01T10:25:57Z

src/Line.tsx


-const Line = ({
+const Line: React.FC<ProgressProps> = ({


函数式组件导出时，写上 displayName 属性。

kerm1it · 2020-09-01T10:26:24Z

src/Line.tsx

@@ -2,8 +2,9 @@
 import React from 'react';


导入 React 的时候最好使用 import * as React from 'React'，否则当 tsconfig 未开启 esModuleInterop 选项时，编译会有问题。

kerm1it · 2020-09-01T10:34:15Z

src/common.ts

@@ -1,20 +1,22 @@
 import { useRef, useEffect } from 'react';
+import { StrokeLinecapType } from './interface';

 export const defaultProps = {


defaultProps 最好加上类型 Partial<ProgressProps>，另外 strokeLinecap 应该可以不用 as

kerm1it · 2020-09-01T13:23:36Z

src/Line.tsx

@@ -60,7 +61,7 @@ const Line = ({
            className={`${prefixCls}-line-path`}
            d={pathString}
            strokeLinecap={strokeLinecap}
-            stroke={color}
+            stroke={color as string}


这个 color 的类型有点迷，可以为 string、string[] 和 object，但是没有看见 object 用到。

object 好像是这种的

{ 0%: 'xxx' 50%: 'xxx' 100%: 'xxx', }

明白了，Line 和 Circle 用的一个 Props 定义，但是有些字段的类型是有分叉的。

kerm1it

我这没啥问题了， @afc163 @zombieJ 你们再看看有没有漏掉的？

afc163 · 2020-09-01T13:37:08Z

我先发一个 minor 版本到 antd 再测测。

chore: use father

ec85e40

xrkffgg changed the title ~~chore: use father~~ [WIP] chore: use father Aug 27, 2020

fix test

8db8fd6

vercel bot deployed to Preview August 31, 2020 06:55 View deployment

afc163 mentioned this pull request Aug 31, 2020

perf: 🆙 upgrade rc-dialog and rc-upload and rc-progress ant-design/ant-design#26494

Merged

22 tasks

change name

ee5c24a

vercel bot deployed to Preview August 31, 2020 07:19 View deployment

update lint

3403106

vercel bot deployed to Preview August 31, 2020 07:32 View deployment

update

669dcb3

vercel bot deployed to Preview August 31, 2020 07:50 View deployment

uptate ci

13d9f1a

vercel bot deployed to Preview August 31, 2020 07:59 View deployment

update

0af9c6a

vercel bot deployed to Preview August 31, 2020 08:06 View deployment

update

f49e0c4

vercel bot deployed to Preview August 31, 2020 08:11 View deployment

update

e09d599

vercel bot deployed to Preview August 31, 2020 08:19 View deployment

update

1f49912

vercel bot deployed to Preview August 31, 2020 09:15 View deployment

afc163 reviewed Aug 31, 2020

View reviewed changes

package.json Outdated

"rc-tools": "9.x",

"react": "^16.9.0",

"react-dom": "^16.9.0",

"typescript": "^3.9.7"

Copy link

Member

afc163 Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^4.0.2

update

59c3880

vercel bot deployed to Preview August 31, 2020 09:21 View deployment

xrkffgg requested a review from zombieJ August 31, 2020 09:41

afc163 reviewed Aug 31, 2020

View reviewed changes

package.json Outdated

"eslint": "^7.6.0",

"father": "^2.29.6",

"np": "^6.5.0",

"rc-tools": "9.x",

Copy link

Member

afc163 Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc-tools 应该没用了。

remove rc-tools

837ab7e

afc163 reviewed Aug 31, 2020

View reviewed changes

zombieJ reviewed Aug 31, 2020

View reviewed changes

update ts

846a463

vercel bot had a problem deploying to Preview September 1, 2020 03:52 Failure

update package

b2afc20

vercel bot had a problem deploying to Preview September 1, 2020 03:57 Failure

kerm1it reviewed Sep 1, 2020

View reviewed changes

fix name up

29464f4

vercel bot had a problem deploying to Preview September 1, 2020 04:58 Failure

add test

c6d8a25

vercel bot deployed to Preview September 1, 2020 05:15 View deployment

xrkffgg marked this pull request as ready for review September 1, 2020 05:19

xrkffgg requested review from afc163 and zombieJ September 1, 2020 05:20

kerm1it reviewed Sep 1, 2020

View reviewed changes

src/Line.tsx

const Line = ({

const Line: React.FC<ProgressProps> = ({

Copy link

Member

kerm1it Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

函数式组件导出时，写上 displayName 属性。

kerm1it reviewed Sep 1, 2020

View reviewed changes

fix example & define

8205255

vercel bot deployed to Preview September 1, 2020 13:07 View deployment

kerm1it reviewed Sep 1, 2020

View reviewed changes

kerm1it approved these changes Sep 1, 2020

View reviewed changes

afc163 merged commit 4bada1e into master Sep 1, 2020

delete-merged-branch bot deleted the up-father branch September 1, 2020 13:35

xrkffgg mentioned this pull request Nov 16, 2020

core-js version #79

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: use father #85

chore: use father #85

xrkffgg commented Aug 27, 2020

vercel bot commented Aug 27, 2020 •

edited

afc163 Aug 31, 2020

xrkffgg commented Aug 31, 2020

zombieJ commented Aug 31, 2020

afc163 Aug 31, 2020

codecov bot commented Aug 31, 2020 •

edited

afc163 Aug 31, 2020

xrkffgg Aug 31, 2020

afc163 Aug 31, 2020

kerm1it Aug 31, 2020

xrkffgg Aug 31, 2020

zombieJ Aug 31, 2020

kerm1it Sep 1, 2020

xrkffgg commented Sep 1, 2020

kerm1it Sep 1, 2020

afc163 Sep 1, 2020

kerm1it Sep 1, 2020

xrkffgg Sep 1, 2020

kerm1it Sep 1, 2020

kerm1it Sep 1, 2020

kerm1it Sep 1, 2020 •

edited

kerm1it Sep 1, 2020

kerm1it Sep 1, 2020 •

edited

xrkffgg Sep 1, 2020

kerm1it Sep 1, 2020

kerm1it left a comment

afc163 commented Sep 1, 2020

		@@ -1,4 +1,4 @@
		import Progress, { Line, Circle } from './src/';
		import Progress, { Line, Circle } from './src';

		@@ -0,0 +1,22 @@
		import * as React from 'react';

		export interface progressProps {

chore: use father #85

chore: use father #85

Conversation

xrkffgg commented Aug 27, 2020

vercel bot commented Aug 27, 2020 • edited

Choose a reason for hiding this comment

xrkffgg commented Aug 31, 2020

zombieJ commented Aug 31, 2020

Choose a reason for hiding this comment

codecov bot commented Aug 31, 2020 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xrkffgg commented Sep 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerm1it Sep 1, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerm1it Sep 1, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerm1it left a comment

Choose a reason for hiding this comment

afc163 commented Sep 1, 2020

vercel bot commented Aug 27, 2020 •

edited

codecov bot commented Aug 31, 2020 •

edited

kerm1it Sep 1, 2020 •

edited

kerm1it Sep 1, 2020 •

edited