fix: type error on picker prop #677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LucasAlencarCosta
changed the title
yoyo837
reviewed
Sep 29, 2023
| @@ -99,7 +99,7 @@ export type PickerPanelBaseProps<DateType> = { | |||
| } & PickerPanelSharedProps<DateType>; | |||
|
|
|||
| export type PickerPanelDateProps<DateType> = { | |||
| picker?: 'date'; | |||
| picker?: 'time' | 'date' | 'week' | 'month' | 'year'; | |||
There was a problem hiding this comment.
type PickerPanelDateProps is works for date only.
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 56 56
Lines 2443 2443
Branches 734 728 -6
=======================================
Hits 2417 2417
Misses 24 24
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Conflicting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing picker prop that is not
' date' | undefinedIt throws a TS error even though other props are accepted by the component such as "month" or "year".