improve: preview props

[hengkx]

ant-design/ant-design#26713 (comment)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/image/kba5rz71a
✅ Preview: https://image-git-refactor-container.react-component.vercel.app

[codecov]

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          143       143           
  Branches        35        36    +1     
=========================================
  Hits           143       143           

Impacted Files	Coverage Δ
src/Image.tsx	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a164d7...20abbbc. Read the comment docs.

[shaodahong]

What is the difference with https://github.com/react-component/image/pull/29？

[hengkx]

预览的参数 改到了 preview里面

[hengkx]

[afc163]

要发个 major 版本。

[shaodahong]

测试失败是这个 react-component/dialog#206 导致的，以前是元素直接干掉了，现在是 display: none 要改下测试

[shaodahong]

是否有必要给dialog 也加一个用例？

感觉底层的库还是在底层测试比较好

[hengkx]

passed 🤗

[shaodahong]

+ rc-image@3.3.0

[afc163]

It is a breaking change, please revert and release a major version.

[shaodahong]

不算 breaking change 吧，原本的 getPopupContainer 没发布 ant-design/ant-design#26713

[hengkx]

应该算是 rc-image 已经发布过了 对他来说 已经是 breaking change 了吧

[afc163]

对 antd 来说没有这个属性，对于 rc-image 发布了。

[yoyo837]

老偏的意思是，有的用户不是通过antd而使用rc-image的

[shaodahong]

+ rc-image@4.0.0

[yoyo837]

是不是还应该发个3.3.1，把这个revert发布出去

[hengkx]

npm 在一定时间内 可以撤销的

[yoyo837]

我是看见npm里有才说的！

那...撤销一下吧

[shaodahong]

撤销不了，已经 deprecate 了

[rfreling]

谢谢你们! 🙏 @afc163 @shaodahong @hengkx @yoyo837