Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dialog support classNames #365

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

kiner-tang
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dialog ❌ Failed (Inspect) Sep 17, 2023 4:26am

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #365 (fad5971) into master (8fb5644) will not change coverage.
The diff coverage is 100.00%.

❗ Current head fad5971 differs from pull request most recent head ef04c3d. Consider uploading reports for the commit ef04c3d to get more accurate results

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files           8        8           
  Lines         165      165           
  Branches       50       50           
=======================================
  Hits          164      164           
  Misses          1        1           
Files Changed Coverage Δ
src/Dialog/index.tsx 98.52% <ø> (ø)
src/Dialog/Content/Panel.tsx 100.00% <100.00%> (ø)
src/Dialog/Mask.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -53,6 +53,7 @@ ReactDOM.render(
| ---------------------- | ------------------------------ | --------- | ------------------------------------------------------------------------------- | ------- |
| prefixCls | String | rc-dialog | The dialog dom node's prefixCls | |
| className | String | | additional className for dialog | |
| classNames | { mask?: string; wrapper?: string; header?: string; body?: string; footer?: string} | | pass className to target area | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这名字个人觉得不太好, 看看有米有更好的想法?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ant-design/ant-design#43372 在这里讨论一下

@MadCcc MadCcc merged commit bdb8573 into react-component:master Sep 18, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants