Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid autofocus #361

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

fix: invalid autofocus #361

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
568ac95
fix: invalid autofocus
acyza Mar 20, 2023
3de72fd
fix: test fail
acyza Mar 20, 2023
5e11aa6
chore: update
acyza Mar 20, 2023
6d0f7bb
chore: update
acyza Mar 21, 2023
da7a732
chore: update
acyza Mar 21, 2023
a2ab585
chore: update
acyza Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DialogWrap.tsx
View file
Open in desktop
@@ -1,5 +1,5 @@
import * as React from 'react';
import Portal from '@rc-component/portal';
import * as React from 'react';
import Dialog from './Dialog';
import type { IDialogPropTypes } from './IDialogPropTypes';

Expand Down Expand Up @@ -41,7 +41,7 @@ const DialogWrap: React.FC<IDialogPropTypes> = (props: IDialogPropTypes) => {
<Portal
open={visible || forceRender || animatedVisible}
autoDestroy={false}
getContainer={getContainer}
getContainer={getContainer === undefined ? 'body' : getContainer}
acyza marked this conversation as resolved.
Show resolved Hide resolved
autoLock={visible || animatedVisible}
>
<Dialog
Expand Down
3 changes: 1 addition & 2 deletions tests/index.spec.tsx
View file
Open in desktop
Expand Up @@ -222,8 +222,7 @@ describe('dialog', () => {
expect(wrapper.find('.rc-dialog-footer').text()).toBe('test');
});

// 失效了，需要修复
it.skip('support input autoFocus', () => {
it('support input autoFocus', () => {
render(
<Dialog visible>
<input autoFocus />
Expand Down