-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility error fixed: ARIA hidden element must not contain focus… #288
Accessibility error fixed: ARIA hidden element must not contain focus… #288
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 98.12% 98.14% +0.02%
==========================================
Files 7 7
Lines 160 162 +2
Branches 50 52 +2
==========================================
+ Hits 157 159 +2
Misses 2 2
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Conflicting |
34fce9f
to
646efc7
Compare
…hub.com/Ke1sy/dialog into fix/accessibility_aria_hidden_error_fix
Hmm...since this dom is used for tab loop in the modal. So if it make to |
I mean current update may not help on a11y since above.
|
@zombieJ I am closing this PR as it's not actual any more, Axe devTools a11y plugin doesn't show this error any more. |
This fix is made to solve the reported issue "Accessibility error: ARIA hidden element must not contain focusable elements" fix #287