Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use father #196

Closed
wants to merge 4 commits into from
Closed

chore: use father #196

wants to merge 4 commits into from

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Aug 19, 2020

No description provided.

@vercel
Copy link

vercel bot commented Aug 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/6ldhug06r
✅ Preview: https://dialog-git-k-father.react-component.vercel.app

import Dialog from '../index';
import '../assets/bootstrap.less';

const { Simulate } = TestUtils;

describe('dialog', () => {
const title = '第一个title';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn test 过不去😂,其他的差不多了。

start 也正常。

@xrkffgg xrkffgg requested a review from zombieJ August 19, 2020 07:14
src/Dialog.tsx Outdated Show resolved Hide resolved
tests/index.spec.js Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

zombieJ commented Aug 19, 2020

CI 挂了……

@zombieJ
Copy link
Member

zombieJ commented Aug 19, 2020

expect 的测试要转成 jest 的测试

@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 19, 2020

😂😂 本来 11 pass ,改了一下 2 pass..... 感觉 这块 越改越乱

大佬出马吧

@xrkffgg xrkffgg closed this Aug 19, 2020
@zombieJ
Copy link
Member

zombieJ commented Aug 20, 2020

别着急,test case 一个个改过来,你可以的~~改了这么多关了多可惜

@zombieJ zombieJ reopened this Aug 20, 2020
@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 20, 2020

New in #197

@xrkffgg xrkffgg closed this Aug 20, 2020
@afc163 afc163 deleted the k-father branch September 2, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants