feat: support draggable dialog #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yiminghe It will be very appreciated if you can take a look at this PR! I'll be happy to get your inputs! |
|
When this PR will be generating a new version? |
naomipol
force-pushed
the
feat-draggable
branch
from
9b2bc9d
to
1f8a227
Compare
|
@afc163 I have fixed the conflicts, could this be merged soon? |
19 tasks
|
Support in #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add draggable functionality to dialog as requested in this issue: #37
I have also tried to wrap the component with react-draggable, but unfortunately it doesn't work like mentioned in this issue: #90
This PR uses react-draggable https://github.com/mzabriskie/react-draggable that wraps the inner dialog element.
An alternative implementation to support draggable functionality could be adding a
dialogElementprop - a custom element that will be passed to wrap the dialog element.This way the consumer could pass the
Draggablecomponent.Please let me know what you think.
I really need this feature!
Thanks.