Handle null or undefined children #11

gpoole · 2016-06-17T07:51:36Z

Handles cases where <Animate /> is declared like so:

<Animate>
  {undefined}
  <div key='example'></div>
</Animate>

I've verified this with a test and in my own case, but please let me know if there's any additional testing needed to make sure this doesn't cause problems?

Fixes #7.

coveralls · 2016-06-17T07:54:35Z

Coverage decreased (-0.4%) to 74.182% when pulling 2f3e941 on gpoole:handle-null-undefined-children into e707fda on react-component:master.

yiminghe · 2016-06-17T08:14:43Z

tests/multiple.spec.js

@@ -138,4 +138,16 @@ describe('Animate', () => {
      done();
    }, 1400);
  });
+
+  it('does not fail with null/undefined children', (done) => {
+    ReactDOM.render(


can you make a complete test?

check whether classnames are added correctly

yiminghe · 2016-07-05T08:12:26Z

ok, thanks

coveralls · 2016-07-05T08:13:24Z

Coverage increased (+0.4%) to 74.912% when pulling 0a256c4 on gpoole:handle-null-undefined-children into e707fda on react-component:master.

Greg Poole added 3 commits June 17, 2016 17:35

Added failing test for undefined child

420da7c

Added fix for null and undefined children

0d96339

Added a test for null children too

2f3e941

yiminghe reviewed Jun 17, 2016
View reviewed changes

Added more comprehensive tests

0a256c4

yiminghe merged commit 3e611db into react-component:master Jul 5, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle null or undefined children #11

Handle null or undefined children #11

gpoole commented Jun 17, 2016

coveralls commented Jun 17, 2016 •

edited

yiminghe Jun 17, 2016

yiminghe commented Jul 5, 2016

coveralls commented Jul 5, 2016

Handle null or undefined children #11

Handle null or undefined children #11

Conversation

gpoole commented Jun 17, 2016

coveralls commented Jun 17, 2016 • edited

yiminghe Jun 17, 2016

Choose a reason for hiding this comment

yiminghe commented Jul 5, 2016

coveralls commented Jul 5, 2016

coveralls commented Jun 17, 2016 •

edited