Locking eslint-plugin-react to 2.5.0 #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be |
mtscout6
force-pushed
the
lock-eslint-plugin-react
branch
from
1e85ca3
to
72f10af
Compare
Due to breaking change in the 2.5.1 release. See: jsx-eslint/eslint-plugin-react#110
|
Good catch fixed. |
|
May not be an issue now that 2.5.2 is out, but I haven't tested yet. |
|
I don't see 2.5.2 on NPM yet. Should we merge this or hold off? |
|
ref jsx-eslint/eslint-plugin-react#110 (comment) @taion can you merge it please if in a 30 minutes there is still no 2.5.2 on npmjs ? |
|
Update: jsx-eslint/eslint-plugin-react#110 (comment) |
|
Yeah. 2.5.2 is out and it works fine. I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to breaking change in the 2.5.1 release.
See: jsx-eslint/eslint-plugin-react#110