New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Docusaurus site #6553
Conversation
O man this is awesome. Really nice to see all the bespoke Gatsby stuff go away |
@jquense, I think I got everything done for the site except for 1 thing. I'm having trouble getting the site to link to the local RB source files properly. The actual linking works (I can import the components), but during render, the site is throwing an error about "invalid hook call" as if I had multiple versions of React installed. Not sure why I'm getting this error. Are you available to help with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome - couple comments. I didn't focus on code that much, mostly I've just checked out the branch and tried everything out, so:
- [subjective]
--ifm-navbar-background-color
looks pretty strange to me - this is just my opinion so feel free to ignore - personally i'd go with something with less contrast - maybe more dark-blue(e.g.#003870
)? @jquense probably has an opinion about it 😄 Getting started
(and each subsequent "container" page, eg.Layout
,Forms
etc.) page - everything appears underlined for me- On each page at the bottom there are link buttons to prev/next page - those appear underlined, I don't think they should be(?)
Layout
->Grid
- first few examples are not really showing much anymore, cause the mage is narrowerForms
->Input Group
->Buttons with dropdowns
->___DEV__ is not defined
alsoSegmented buttons
part + API part seems to be broken tooComponents
"wrapper" page has a placeholder copy - I'd remove it/improve itBreadcrumbs
example "home" appears like it's got a slight css problemComponents
->Button group
->Nesting
/Vertical variation
->__DEV__ is not defined
Components
->Dropdowns
->__DEV__ is not defined
on every exampleComponents
->Navbars
->Overview
/Scrolling
/Responsive behaviors
/Offcanvas
->__DEV__ is not defined
and no icon inBrand
section(image doesn't load)Components
->Navs and tabs
->Using dropdowns
__DEV__ is not defined
and in API sectiononSelect
appears to be a code block, which looks pretty weirdComponents
->Pagination
->API
seems to slightly broken
^all the hyperlinks point to localhost
But overall I love how all of this looks - this is a big improvement over gatsby both from usage and visual standpoint
Thanks for the detailed review! I should've checked the examples after fixing the local components integration 🤦♂️ |
Fixed all the issues except these:
Yeah not sure what to do with this. I'd like to try implementing the dark mode on the site when we integrate BS 5.3, so we could probably change more. Future PR?
These examples were the same as the old site and you can kinda see the difference when you resize the screen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. I wonder tho if its worth holding back merging to the real docs until we can add a RB theme to use? I feel really weird weird having a doc site for a UI library that doesn't use the UI library, dog fooding in this way is probably a minimum. I also agree about the color, it's really bright and feels a little out of character, should we keep some of the older style greys? |
I can probably take a stab at implementing the base theme btw, i've done it before, so should be relatively quick |
I was thinking of using the older styles for dark mode on the site. Doesn't matter too much tho |
Did you get a chance to look at the theme stuff @jquense? Anything I can help with? |
no :( i have no less than no time unfortunately. Lets not block on me since i have no idea when i could get to it now |
No worries @jquense. I'll merge this first since it's so large and we can iterate on it later. |
Docusaurus site
Preview: https://deploy-preview-6553--react-bootstrap.netlify.app/
Checklist:
react-bootstrap
library. Currently uses the npm release.Closes #6510
Closes #6277
Closes #5317
Closes #5310
Closes #5241
Closes #5214