Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): move all the types dependencies to dev dependencies #6300

Closed
wants to merge 1 commit into from

Conversation

gmukul01
Copy link

@gmukul01 gmukul01 commented Apr 8, 2022

Moving all types dependencies to dev dependencies.

This fixes #6299

@kyletsang
Copy link
Member

Thanks for opening a PR, but the types actually do belong in the dependencies. See @jquense's response in #6299

Types are supposed to be in dependencies because they need to be installed when some one installs the package. Other wise typescript will not be able to correctly typecheck when you use react-bootstap

@kyletsang kyletsang closed this Apr 8, 2022
@gmukul01
Copy link
Author

gmukul01 commented Apr 9, 2022

@kyletsang At least we can move it to peerDependency. Keeping it in dependency is failing our project because it is installing latest version on react types(v18) which is not compatible as of now in our project. And since it is in dependency we can not control the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove @types/* from dependencies
2 participants