-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace custom build scripts w/ Preconstruct #732
Conversation
@Andarist this change is inspired by your mentioning of this project at one point, so if you have any thoughts or suggestions for effectively working within Preconstruct's constraints I'd be glad to hear them. I've already found myself itching for a few things here that I can no longer access, but I'm trying to convince myself it isn't worth it 😛 |
I like how you have summed up the cons If you ever find a need to fork - let's discuss it first :) |
"tslib": "^2.0.0" | ||
}, | ||
"peerDependencies": { | ||
"react": "^16.8.0 || 17.x", | ||
"react-dom": "^16.8.0 || 17.x" | ||
}, | ||
"main": "dist/index.js", | ||
"module": "dist/accordion.esm.js", | ||
"typings": "dist/index.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you would be willing to help with this issue: preconstruct/preconstruct#259 ? :>
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4680d49:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Spread that Preconstruct love ❤️
c2805e9
to
4680d49
Compare
This PR replaces the current build scripts, which were forked and simplified based on tsdx, with Preconstruct. The tradeoffs of this change as I see it are:
Pros:
preconstruct dev
Cons:
yarn test
).yarn start
).This pull request: