Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop and rubocop-rspec #2499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 12, 2023

Bumps rubocop and rubocop-rspec. These dependencies needed to be updated together.
Updates rubocop from 0.93.1 to 1.59.0

Release notes

Sourced from rubocop's releases.

RuboCop 1.59

New features

Bug fixes

  • #12434: Fix a false positive for Lint/LiteralAssignmentInCondition when using interpolated string or xstring literals. (@​koic)
  • #12435: Fix a false positive for Lint/SelfAssignment when using attribute assignment with method call with arguments. (@​koic)
  • #12444: Fix false positive for Style/HashEachMethods when receiver literal is not a hash literal. (@​koic)
  • #12524: Fix a false positive for Style/MethodCallWithArgsParentheses when EnforcedStyle: omit_parentheses and parens in when clause is used to pass an argument. (@​koic)
  • #12505: Fix a false positive for Style/RedundantParentheses when using parenthesized lambda or proc with do...end block. (@​koic)
  • #12442: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data as previous loop in do...end and {...} blocks. (@​koic)
  • #12432: Fix a false positive for Lint/LiteralAssignmentInCondition when using parallel assignment with splat operator in block of guard condition. (@​koic)
  • #12441: Fix false positives for Style/HashEachMethods when using destructed block arguments. (@​koic)
  • #12436: Fix false positives for Style/RedundantParentheses when a part of range is a parenthesized condition. (@​koic)
  • #12429: Fix incorrect autocorrect for Style/MapToHash when using dot method calls for to_h. (@​koic)
  • #12488: Make Lint/HashCompareByIdentity aware of safe navigation operator. (@​koic)
  • #12489: Make Lint/NextWithoutAccumulator aware of safe navigation operator. (@​koic)
  • #12490: Make Lint/NumberConversion aware of safe navigation operator. (@​koic)
  • #12491: Make Lint/RedundantWithIndex aware of safe navigation operator. (@​koic)
  • #12492: Make Lint/RedundantWithObject aware of safe navigation operator. (@​koic)
  • #12493: Make Lint/UnmodifiedReduceAccumulator aware of safe navigation operator. (@​koic)
  • #12473: Make Style/ClassCheck aware of safe navigation operator. (@​koic)
  • #12445: Make Style/CollectionCompact aware of safe navigation operator. (@​koic)
  • #12474: Make Style/ConcatArrayLiterals aware of safe navigation operator. (@​koic)
  • #12476: Make Style/DateTime aware of safe navigation operator. (@​koic)
  • #12479: Make Style/EachWithObject aware of safe navigation operator. (@​koic)
  • #12446: Make Style/HashExcept aware of safe navigation operator. (@​koic)
  • #12447: Make Style/MapCompactWithConditionalBlock aware of safe navigation operator. (@​koic)
  • #12484: Make Style/Next aware of safe navigation operator. (@​koic)
  • #12486: Make Style/RedundantArgument aware of safe navigation operator. (@​koic)
  • #12454: Make Style/RedundantFetchBlock aware of safe navigation operator. (@​koic)
  • #12495: Make Layout/RedundantLineBreak aware of safe navigation operator. (@​koic)
  • #12455: Make Style/RedundantSortBy aware of safe navigation operator. (@​koic)
  • #12456: Make Style/RedundantSortBy aware of safe navigation operator. (@​koic)
  • #12480: Make Style/ExactRegexpMatch aware of safe navigation operator. (@​koic)
  • #12457: Make Style/Sample aware of safe navigation operator. (@​koic)
  • #12458: Make Style/SelectByRegexp cops aware of safe navigation operator. (@​koic)
  • #12494: Make Layout/SingleLineBlockChain aware of safe navigation operator. (@​koic)
  • #12461: Make Style/StringChars aware of safe navigation operator. (@​koic)
  • #12468: Make Style/Strip aware of safe navigation operator. (@​koic)
  • #12469: Make Style/UnpackFirst aware of safe navigation operator. (@​koic)

Changes

  • #12522: Make Style/MethodCallWithoutArgsParentheses allow the parenthesized it method in a block. (@​koic)
  • #12523: Make Style/RedundantSelf allow the self.it method in a block. (@​koic)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.59.0 (2023-12-11)

New features

Bug fixes

  • #12434: Fix a false positive for Lint/LiteralAssignmentInCondition when using interpolated string or xstring literals. ([@​koic][])
  • #12435: Fix a false positive for Lint/SelfAssignment when using attribute assignment with method call with arguments. ([@​koic][])
  • #12444: Fix false positive for Style/HashEachMethods when receiver literal is not a hash literal. ([@​koic][])
  • #12524: Fix a false positive for Style/MethodCallWithArgsParentheses when EnforcedStyle: omit_parentheses and parens in when clause is used to pass an argument. ([@​koic][])
  • #12505: Fix a false positive for Style/RedundantParentheses when using parenthesized lambda or proc with do...end block. ([@​koic][])
  • #12442: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data as previous loop in do...end and {...} blocks. ([@​koic][])
  • #12432: Fix a false positive for Lint/LiteralAssignmentInCondition when using parallel assignment with splat operator in block of guard condition. ([@​koic][])
  • #12441: Fix false positives for Style/HashEachMethods when using destructed block arguments. ([@​koic][])
  • #12436: Fix false positives for Style/RedundantParentheses when a part of range is a parenthesized condition. ([@​koic][])
  • #12429: Fix incorrect autocorrect for Style/MapToHash when using dot method calls for to_h. ([@​koic][])
  • #12488: Make Lint/HashCompareByIdentity aware of safe navigation operator. ([@​koic][])
  • #12489: Make Lint/NextWithoutAccumulator aware of safe navigation operator. ([@​koic][])
  • #12490: Make Lint/NumberConversion aware of safe navigation operator. ([@​koic][])
  • #12491: Make Lint/RedundantWithIndex aware of safe navigation operator. ([@​koic][])
  • #12492: Make Lint/RedundantWithObject aware of safe navigation operator. ([@​koic][])
  • #12493: Make Lint/UnmodifiedReduceAccumulator aware of safe navigation operator. ([@​koic][])
  • #12473: Make Style/ClassCheck aware of safe navigation operator. ([@​koic][])
  • #12445: Make Style/CollectionCompact aware of safe navigation operator. ([@​koic][])
  • #12474: Make Style/ConcatArrayLiterals aware of safe navigation operator. ([@​koic][])
  • #12476: Make Style/DateTime aware of safe navigation operator. ([@​koic][])
  • #12479: Make Style/EachWithObject aware of safe navigation operator. ([@​koic][])
  • #12446: Make Style/HashExcept aware of safe navigation operator. ([@​koic][])
  • #12447: Make Style/MapCompactWithConditionalBlock aware of safe navigation operator. ([@​koic][])
  • #12484: Make Style/Next aware of safe navigation operator. ([@​koic][])
  • #12486: Make Style/RedundantArgument aware of safe navigation operator. ([@​koic][])
  • #12454: Make Style/RedundantFetchBlock aware of safe navigation operator. ([@​koic][])
  • #12495: Make Layout/RedundantLineBreak aware of safe navigation operator. ([@​koic][])
  • #12455: Make Style/RedundantSortBy aware of safe navigation operator. ([@​koic][])
  • #12456: Make Style/RedundantSortBy aware of safe navigation operator. ([@​koic][])
  • #12480: Make Style/ExactRegexpMatch aware of safe navigation operator. ([@​koic][])
  • #12457: Make Style/Sample aware of safe navigation operator. ([@​koic][])
  • #12458: Make Style/SelectByRegexp cops aware of safe navigation operator. ([@​koic][])
  • #12494: Make Layout/SingleLineBlockChain aware of safe navigation operator. ([@​koic][])
  • #12461: Make Style/StringChars aware of safe navigation operator. ([@​koic][])
  • #12468: Make Style/Strip aware of safe navigation operator. ([@​koic][])
  • #12469: Make Style/UnpackFirst aware of safe navigation operator. ([@​koic][])

Changes

  • #12522: Make Style/MethodCallWithoutArgsParentheses allow the parenthesized it method in a block. ([@​koic][])
  • #12523: Make Style/RedundantSelf allow the self.it method in a block. ([@​koic][])

... (truncated)

Commits
  • e5a164a Cut 1.59
  • 2912b6e Update Changelog
  • 3bcc171 [Fix #12524] Fix a false positive for Style/MethodCallWithArgsParentheses
  • 0daa4aa Make Style/MethodCallWithoutArgsParentheses allow parenthesized it
  • b240a09 Make Style/RedundantSelf allow self.it
  • a0e1042 [Fix #12526] Fix incorrect rendering typos
  • b1bcb31 [Fix #12444] Fix false positive for Style/HashEachMethods
  • 3b0360b Add new Lint/ItWithoutArgumentsInBlock cop
  • 4e9cfcc Merge pull request #12521 from koic/make_style_select_by_regexp_aware_of_safe...
  • 037c860 Merge pull request #12438 from koic/fix_a_false_positive_for_lint_literal_ass...
  • Additional commits viewable in compare view

Updates rubocop-rspec from 1.44.1 to 2.25.0

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.25.0

  • Add support single quoted string and percent string and heredoc for RSpec/Rails/HttpStatus. (@​ydah)
  • Change to be inline disable for RSpec/SpecFilePathFormat like RSpec/FilePath. (@​ydah)
  • Fix a false positive for RSpec/MetadataStyle with example groups having multiple string arguments. (@​franzliedke)

RuboCop RSpec v2.24.1

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. (@​ydah)

RuboCop RSpec v2.24.0

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is enabled by default, the two new cops are pending and need to be enabled explicitly. (@​ydah)
  • Add new RSpec/Eq cop. (@​ydah)
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. (@​r7kamura)
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. (@​ydah)
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. (@​bcgraham)
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. (@​marocchino)
  • Fix a false positive RSpec/Focus when chained method call and inside define method. (@​ydah)

RuboCop RSpec v2.23.2

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. (@​marocchino)
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. (@​marocchino)

RuboCop RSpec v2.23.1

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. (@​ydah)
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. (@​bquorning)

RuboCop RSpec v2.23.0

  • Add new RSpec/Rails/NegationBeValid cop. (@​ydah)
  • Fix a false negative for RSpec/ExcessiveDocstringSpacing when finds description with em space. (@​ydah)
  • Fix a false positive for RSpec/EmptyExampleGroup when example group with examples defined in if branch inside iterator. (@​ydah)
  • Update the message output of RSpec/ExpectActual to include the word 'value'. ([@​corydiamand])
  • Fix a false negative for RSpec/Pending when it without body. (@​ydah)
  • Add new RSpec/ReceiveMessages cop. (@​ydah)
  • Change default.yml path to use **/spec/* instead of spec/*. (@​ydah)
  • Add AllowedIdentifiers and AllowedPatterns configuration option to RSpec/IndexedLet. (@​ydah)
  • Fix RSpec/NamedSubject when block has no body. ([@​splattael])

... (truncated)

Changelog

Sourced from rubocop-rspec's changelog.

2.25.0 (2023-10-27)

  • Add support single quoted string and percent string and heredoc for RSpec/Rails/HttpStatus. ([@​ydah])
  • Change to be inline disable for RSpec/SpecFilePathFormat like RSpec/FilePath. ([@​ydah])
  • Fix a false positive for RSpec/MetadataStyle with example groups having multiple string arguments. ([@​franzliedke])

2.24.1 (2023-09-23)

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. ([@​ydah])

2.24.0 (2023-09-08)

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is disabled by default and the two new cops are pending and need to be enabled explicitly. ([@​ydah])
  • Add new RSpec/Eq cop. ([@​ydah])
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. ([@​r7kamura])
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. ([@​ydah])
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. ([@​bcgraham])
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. ([@​marocchino])
  • Fix a false positive RSpec/Focus when chained method call and inside define method. ([@​ydah])

2.23.2 (2023-08-09)

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. ([@​marocchino])
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. ([@​marocchino])

2.23.1 (2023-08-07)

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. ([@​ydah])
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. ([@​bquorning])

2.23.0 (2023-07-30)

  • Add new RSpec/Rails/NegationBeValid cop. ([@​ydah])
  • Fix a false negative for RSpec/ExcessiveDocstringSpacing when finds description with em space. ([@​ydah])
  • Fix a false positive for RSpec/EmptyExampleGroup when example group with examples defined in if branch inside iterator. ([@​ydah])
  • Update the message output of RSpec/ExpectActual to include the word 'value'. ([@​corydiamand])
  • Fix a false negative for RSpec/Pending when it without body. ([@​ydah])
  • Add new RSpec/ReceiveMessages cop. ([@​ydah])
  • Change default.yml path to use **/spec/* instead of spec/*. ([@​ydah])
  • Add AllowedIdentifiers and AllowedPatterns configuration option to RSpec/IndexedLet. ([@​ydah])
  • Fix RSpec/NamedSubject when block has no body. ([@​splattael])
  • Fix RSpec/LetBeforeExamples autocorrect incompatible with RSpec/ScatteredLet autocorrect. ([@​ydah])
  • Update RSpec/Focus to support shared_context and shared_examples. ([@​tmaier])

2.22.0 (2023-05-06)

  • Extract factory_bot cops to a separate repository, rubocop-factory_bot. The rubocop-factory_bot repository is a dependency of rubocop-rspec and the factory_bot cops are aliased (RSpec/FactoryBot/Foo == FactoryBot/Foo) until v3.0 is released, so the change will be invisible to users until then. ([@​ydah])

2.21.0 (2023-05-05)

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [rubocop](https://github.com/rubocop/rubocop) and [rubocop-rspec](https://github.com/rubocop/rubocop-rspec). These dependencies needed to be updated together.

Updates `rubocop` from 0.93.1 to 1.59.0
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.93.1...v1.59.0)

Updates `rubocop-rspec` from 1.44.1 to 2.25.0
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v1.44.1...v2.25.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants