Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop, fancybox2-rails, globalize, rubocop-rspec and tolk #2445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 29, 2023

Bumps rubocop, fancybox2-rails, globalize, rubocop-rspec and tolk. These dependencies needed to be updated together.
Updates rubocop from 0.93.1 to 1.56.4

Release notes

Sourced from rubocop's releases.

RuboCop 1.56.4

Bug fixes

  • #12221: Fix a false positive for Layout/EmptyLineAfterGuardClause when using return before guard condition with heredoc. (@​koic)
  • #12213: Fix a false positive for Lint/OrderedMagicComments when comment text # encoding: ISO-8859-1 is embedded within example code as source code comment. (@​koic)
  • #12205: Fix an error for Style/OperatorMethodCall when using foo bar./ baz. (@​koic)
  • #12208: Fix an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array. (@​koic)
  • #12203: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with comparison operator as an expression of logical operator or comparison operator's operand. (@​koic)
  • #12206: Fix an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar. (@​koic)
  • #12202: Fix an incorrect autocorrect for Style/RedundantConditional when unless/else with boolean results. (@​ydah)
  • #12199: Fix false negatives for Layout/MultilineMethodCallIndentation when using safe navigation operator. (@​koic)

Changes

  • #12197: Make Style/CollectionMethods aware of collect_concat. (@​koic)

RuboCop 1.56.3

Bug fixes

  • #12151: Make Layout/EmptyLineAfterGuardClause allow :nocov: directive after guard clause. (@​koic)
  • #12195: Fix a false negative for Layout/SpaceAfterNot when a newline is present after !. (@​ymap)
  • #12192: Fix a false positive for Layout/RedundantLineBreak when using quoted symbols with a single newline. (@​ymap)
  • #12190: Fix a false positive for Layout/SpaceAroundOperators when aligning operators vertically. (@​koic)
  • #12171: Fix a false positive for Style/ArrayIntersect when using block argument for Enumerable#any?. (@​koic)
  • #12172: Fix a false positive for Style/EmptyCaseCondition when using return, break, next or method call before empty case condition. (@​koic)
  • #12162: Fix an error for Bundler/DuplicatedGroup when there's a duplicate set of groups and the group value contains a splat. (@​koic)
  • #12182: Fix an error for Lint/UselessAssignment when variables are assigned using chained assignment and remain unreferenced. (@​koic)
  • #12181: Fix an incorrect autocorrect for Lint/UselessAssignment when variables are assigned with sequential assignment using the comma operator and unreferenced. (@​koic)
  • #12187: Fix an incorrect autocorrect for Style/SoleNestedConditional when comment is in an empty nested if body. (@​ymap)
  • #12183: Fix an incorrect autocorrect for Style/MultilineTernaryOperator when returning a multiline ternary operator expression with safe navigation method call. (@​koic)
  • #12168: Fix bug in Style/ArgumentsForwarding when there are repeated send nodes. (@​owst)
  • #12185: Set target version for Layout/HeredocIndentation. (@​tagliala)

RuboCop 1.56.2

Bug fixes

  • #12138: Fix a false positive for Layout/LineContinuationLeadingSpace when a backslash is part of a multiline string literal. (@​ymap)
  • #12155: Fix false positive for Layout/RedundantLineBreak when using a modified singleton method definition. (@​koic)
  • #12143: Fix a false positive for Lint/ToEnumArguments when using anonymous keyword arguments forwarding. (@​koic)
  • #12148: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using FileUtils.remove_dir, FileUtils.remove_entry, or FileUtils.remove_entry_secure. (@​koic)
  • #12141: Fix false positive for Style/ArgumentsForwarding when method def includes additional kwargs. (@​owst)
  • #12154: Fix incorrect diagnosticProvider value of LSP. (@​koic)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.56.4 (2023-09-28)

Bug fixes

  • #12221: Fix a false positive for Layout/EmptyLineAfterGuardClause when using return before guard condition with heredoc. ([@​koic][])
  • #12213: Fix a false positive for Lint/OrderedMagicComments when comment text # encoding: ISO-8859-1 is embedded within example code as source code comment. ([@​koic][])
  • #12205: Fix an error for Style/OperatorMethodCall when using foo bar./ baz. ([@​koic][])
  • #12208: Fix an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array. ([@​koic][])
  • #12203: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with comparison operator as an expression of logical operator or comparison operator's operand. ([@​koic][])
  • #12206: Fix an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar. ([@​koic][])
  • #12202: Fix an incorrect autocorrect for Style/RedundantConditional when unless/else with boolean results. ([@​ydah][])
  • #12199: Fix false negatives for Layout/MultilineMethodCallIndentation when using safe navigation operator. ([@​koic][])

Changes

  • #12197: Make Style/CollectionMethods aware of collect_concat. ([@​koic][])

1.56.3 (2023-09-11)

Bug fixes

  • #12151: Make Layout/EmptyLineAfterGuardClause allow :nocov: directive after guard clause. ([@​koic][])
  • #12195: Fix a false negative for Layout/SpaceAfterNot when a newline is present after !. ([@​ymap][])
  • #12192: Fix a false positive for Layout/RedundantLineBreak when using quoted symbols with a single newline. ([@​ymap][])
  • #12190: Fix a false positive for Layout/SpaceAroundOperators when aligning operators vertically. ([@​koic][])
  • #12171: Fix a false positive for Style/ArrayIntersect when using block argument for Enumerable#any?. ([@​koic][])
  • #12172: Fix a false positive for Style/EmptyCaseCondition when using return, break, next or method call before empty case condition. ([@​koic][])
  • #12162: Fix an error for Bundler/DuplicatedGroup when there's a duplicate set of groups and the group value contains a splat. ([@​koic][])
  • #12182: Fix an error for Lint/UselessAssignment when variables are assigned using chained assignment and remain unreferenced. ([@​koic][])
  • #12181: Fix an incorrect autocorrect for Lint/UselessAssignment when variables are assigned with sequential assignment using the comma operator and unreferenced. ([@​koic][])
  • #12187: Fix an incorrect autocorrect for Style/SoleNestedConditional when comment is in an empty nested if body. ([@​ymap][])
  • #12183: Fix an incorrect autocorrect for Style/MultilineTernaryOperator when returning a multiline ternary operator expression with safe navigation method call. ([@​koic][])
  • #12168: Fix bug in Style/ArgumentsForwarding when there are repeated send nodes. ([@​owst][])
  • #12185: Set target version for Layout/HeredocIndentation. ([@​tagliala][])

1.56.2 (2023-08-29)

Bug fixes

  • #12138: Fix a false positive for Layout/LineContinuationLeadingSpace when a backslash is part of a multiline string literal. ([@​ymap][])
  • #12155: Fix false positive for Layout/RedundantLineBreak when using a modified singleton method definition. ([@​koic][])
  • #12143: Fix a false positive for Lint/ToEnumArguments when using anonymous keyword arguments forwarding. ([@​koic][])
  • #12148: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using FileUtils.remove_dir, FileUtils.remove_entry, or FileUtils.remove_entry_secure. ([@​koic][])
  • #12141: Fix false positive for Style/ArgumentsForwarding when method def includes additional kwargs. ([@​owst][])
  • #12154: Fix incorrect diagnosticProvider value of LSP. ([@​koic][])

1.56.1 (2023-08-21)

Bug fixes

... (truncated)

Commits
  • fc57892 Cut 1.56.4
  • b7d99b8 Update Changelog
  • 0f55002 Merge pull request #12222 from koic/fix_a_false_positive_for_layout_empty_lin...
  • 59fb188 Merge pull request #12220 from koic/fix_an_incorrect_autocorrect_for_disable_...
  • 9b04830 [Fix #12221] Fix a false positive for Layout/EmptyLineAfterGuardClause
  • d0d612e [Fix #12208] Fix an incorrect autocorrect for the --disable-uncorrectable o...
  • c626229 Merge pull request #12218 from koic/fix_a_false_positive_for_lint_ordered_mag...
  • a2c1100 [Fix #12213] Fix a false positive for Lint/OrderedMagicComments
  • 3e92160 Disable RSpec/FilePath to resolve build error
  • 1e43822 Merge pull request #12215 from koic/update_the_doc_of_style_return_nil
  • Additional commits viewable in compare view

Updates fancybox2-rails from 785561e to 0.2.8

Commits

Updates globalize from 3c146ab to 6.2.1

Commits

Updates rubocop-rspec from 1.44.1 to 2.24.1

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.24.1

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. (@​ydah)

RuboCop RSpec v2.24.0

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is enabled by default, the two new cops are pending and need to be enabled explicitly. (@​ydah)
  • Add new RSpec/Eq cop. (@​ydah)
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. (@​r7kamura)
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. (@​ydah)
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. (@​bcgraham)
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. (@​marocchino)
  • Fix a false positive RSpec/Focus when chained method call and inside define method. (@​ydah)

RuboCop RSpec v2.23.2

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. (@​marocchino)
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. (@​marocchino)

RuboCop RSpec v2.23.1

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. (@​ydah)
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. (@​bquorning)

RuboCop RSpec v2.23.0

  • Add new RSpec/Rails/NegationBeValid cop. (@​ydah)
  • Fix a false negative for RSpec/ExcessiveDocstringSpacing when finds description with em space. (@​ydah)
  • Fix a false positive for RSpec/EmptyExampleGroup when example group with examples defined in if branch inside iterator. (@​ydah)
  • Update the message output of RSpec/ExpectActual to include the word 'value'. (@​corydiamand)
  • Fix a false negative for RSpec/Pending when it without body. (@​ydah)
  • Add new RSpec/ReceiveMessages cop. (@​ydah)
  • Change default.yml path to use **/spec/* instead of spec/*. (@​ydah)
  • Add AllowedIdentifiers and AllowedPatterns configuration option to RSpec/IndexedLet. (@​ydah)
  • Fix RSpec/NamedSubject when block has no body. (@​splattael)
  • Fix RSpec/LetBeforeExamples autocorrect incompatible with RSpec/ScatteredLet autocorrect. (@​ydah)
  • Update RSpec/Focus to support shared_context and shared_examples (@​tmaier)

... (truncated)

Changelog

Sourced from rubocop-rspec's changelog.

2.24.1 (2023-09-23)

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. ([@​ydah])

2.24.0 (2023-09-08)

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is disabled by default and the two new cops are pending and need to be enabled explicitly. ([@​ydah])
  • Add new RSpec/Eq cop. ([@​ydah])
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. ([@​r7kamura])
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. ([@​ydah])
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. ([@​bcgraham])
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. ([@​marocchino])
  • Fix a false positive RSpec/Focus when chained method call and inside define method. ([@​ydah])

2.23.2 (2023-08-09)

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. ([@​marocchino])
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. ([@​marocchino])

2.23.1 (2023-08-07)

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. ([@​ydah])
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. ([@​bquorning])

2.23.0 (2023-07-30)

  • Add new RSpec/Rails/NegationBeValid cop. ([@​ydah])
  • Fix a false negative for RSpec/ExcessiveDocstringSpacing when finds description with em space. ([@​ydah])
  • Fix a false positive for RSpec/EmptyExampleGroup when example group with examples defined in if branch inside iterator. ([@​ydah])
  • Update the message output of RSpec/ExpectActual to include the word 'value'. ([@​corydiamand])
  • Fix a false negative for RSpec/Pending when it without body. ([@​ydah])
  • Add new RSpec/ReceiveMessages cop. ([@​ydah])
  • Change default.yml path to use **/spec/* instead of spec/*. ([@​ydah])
  • Add AllowedIdentifiers and AllowedPatterns configuration option to RSpec/IndexedLet. ([@​ydah])
  • Fix RSpec/NamedSubject when block has no body. ([@​splattael])
  • Fix RSpec/LetBeforeExamples autocorrect incompatible with RSpec/ScatteredLet autocorrect. ([@​ydah])
  • Update RSpec/Focus to support shared_context and shared_examples. ([@​tmaier])

2.22.0 (2023-05-06)

  • Extract factory_bot cops to a separate repository, rubocop-factory_bot. The rubocop-factory_bot repository is a dependency of rubocop-rspec and the factory_bot cops are aliased (RSpec/FactoryBot/Foo == FactoryBot/Foo) until v3.0 is released, so the change will be invisible to users until then. ([@​ydah])

2.21.0 (2023-05-05)

  • Fix a false positive in RSpec/IndexedLet with suffixes after index-like numbers. ([@​pirj])
  • Fix an error for RSpec/Rails/HaveHttpStatus with comparison with strings containing non-numeric characters. ([@​ydah])
  • Fix an error for RSpec/MatchArray when match_array with no argument. ([@​ydah])
  • Add support a_block_changing and changing for RSpec/ChangeByZero. ([@​ydah])
  • Drop Ruby 2.6 support. ([@​ydah])

... (truncated)

Commits
  • 35d0a2f Merge pull request #1727 from rubocop/release
  • 178a518 Bump version to v2.24.1
  • e7d0fd5 Merge pull request #1718 from rubocop/fix-braking
  • c3d53d9 Fix an error when using RSpec/FilePath and revert to enabled by default
  • 865ea17 Merge pull request #1721 from rubocop/fix-project-spec
  • 19a4b9b Add test for does not use consecutive whitespaces
  • 287bc97 Fix errors in changelog_spec tests
  • b99bf78 Switch docs version back
  • 7488573 Merge pull request #1708 from rubocop/release
  • 9d219df Bump version to v2.24.0
  • Additional commits viewable in compare view

Updates tolk from 8342a4e to 4.2.0

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-and-fancybox2-rails-and-globalize-and-rubocop-rspec-and-tolk-1.56.4 branch 2 times, most recently from aecde4a to 4965997 Compare September 29, 2023 02:51
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-and-fancybox2-rails-and-globalize-and-rubocop-rspec-and-tolk-1.56.4 branch 3 times, most recently from bf964e1 to 0626e4f Compare October 9, 2023 13:32
Bumps [rubocop](https://github.com/rubocop/rubocop), [fancybox2-rails](https://github.com/sureswiftcapital/fancybox2-rails), [globalize](https://github.com/globalize/globalize), [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) and [tolk](https://github.com/rdunlop/tolk). These dependencies needed to be updated together.

Updates `rubocop` from 0.93.1 to 1.56.4
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.93.1...v1.56.4)

Updates `fancybox2-rails` from `785561e` to 0.2.8
- [Commits](sureswiftcapital/fancybox2-rails@785561e...v0.2.8)

Updates `globalize` from `3c146ab` to 6.2.1
- [Commits](globalize/globalize@3c146ab...v6.2.1)

Updates `rubocop-rspec` from 1.44.1 to 2.24.1
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v1.44.1...v2.24.1)

Updates `tolk` from `8342a4e` to 4.2.0
- [Commits](https://github.com/rdunlop/tolk/commits)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: fancybox2-rails
  dependency-type: direct:production
- dependency-name: globalize
  dependency-type: direct:production
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: tolk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-and-fancybox2-rails-and-globalize-and-rubocop-rspec-and-tolk-1.56.4 branch from 0626e4f to ae2fea9 Compare October 9, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants