serve/docker: allow to customize proxy settings of docker plugin #5658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandeex
force-pushed
the
pr-docker-proxy-vars
branch
from
8fb0ff6
to
261ff6d
Compare
ivandeex
force-pushed
the
pr-docker-proxy-vars
branch
from
261ff6d
to
d4665a5
Compare
Closed
ncw
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
This patch allows users to adjust the following environment variables on the docker volume plugin:
HTTP_PROXY HTTPS_PROXY NO_PROXY
Most rclone backends are https(s) based and internally dial a provider's http(s) site using the rclone-extended go dialer honoring the environment settings above.
Note that since go 1.16 (see golang/go#40909) the semantics has changed slightly and HTTP_PROXY does not affect httpS connections anymore.
Was the change discussed in an issue or in the forum before?
No
Checklist
@ncw Please review