Relax java version regexp #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the java version to be specified as "9", instead of "1.9". Closes #1135
|
Actually jruby-9.1.13.0 doesn't install with java 9 because jruby-openssl has the exact same problem with the version. Maybe this shouldn't be merged unless the whole thing works. |
|
@juanibiapina Thanks for your patch. If you have an improvement in this patch, Please submit again. I will merge this because I hope to care JRuby and rbenv users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the java version to be specified as "9", instead of "1.9".
Closes #1135