Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue & pull request template #312

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

issue & pull request template #312

wants to merge 3 commits into from

Conversation

ankitdas13
Copy link
Contributor

No description provided.

Copy link

@sidag95 sidag95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

id: what-happened
attributes:
label: Describe the Issue
description: A clear and concise description of what the issue is.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deleted. Describe the Issue already is very clear.

Comment on lines +28 to +34
- type: textarea
id: expected-behavior
attributes:
label: Expected behavior
description: A clear and concise description of what you expected to happen.
validations:
required: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need one more block after this Actual Behaviour

- type: textarea
id: additional-context
attributes:
label: Additional context

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: Additional context
label: Additional Information

id: additional-context
attributes:
label: Additional context
description: Add any other context about the problem here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Add any other context about the problem here.
description: Add any other information about the problem here.

Comment on lines +1 to +9
## Description
- Description of change

## Detailed Changes

## Additional Info
- Type of PR (bugfix, feature)
- Fixes (issue link)
- Screenshots (if any)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets tackle this in a separate PR.
Lets keep this PR focused on the issues template

id: expected-behavior
attributes:
label: Expected behavior
description: A clear and concise description of what you expected to happen.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deleted.

@kkyusufk kkyusufk self-assigned this Sep 20, 2022
@kkyusufk kkyusufk added this to the SDK Improvements milestone Sep 20, 2022
@ankitdas13
Copy link
Contributor Author

ankitdas13 commented Sep 20, 2022

@kkyusufk @sidag95 going to create separate pr for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants