New: Update graphql variables to camelCase #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harkotha2
changed the title
|
We need to make sure we give the core and UI teams a heads up before we deploy this change. |
yingwang-us
changed the title
dalehille
previously approved these changes
Jul 1, 2020
dalehille
previously approved these changes
Jul 2, 2020
yingwang-us
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we updated all graphql methods, parameters, output varible names to camel-case. Note: values in JSON fields might not be updated.
Note: There is no impact on db, we continue using org_id, cluster_id, etc in mongo db. The changes are done purely by utilizing nodejs alias and mongoose alias.
Temporarily whitelist https://www.npmjs.com/advisories/1523 until there is a fix merged into lodash lodash/lodash#4759