Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow remoteType to be overridden at the Version level #1230

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

carrolp
Copy link
Contributor

@carrolp carrolp commented Oct 12, 2022

If it becomes desirable to allow having a mix of multiple remoteTypes (e.g. both github and gitlab) Versions under the same Channel, this change will allow it:

  • remoteType can still be set on the Channel, but becomes optional
  • remoteType can be set on each Version
  • The remoteType from the Version is used if set, else the one from the Channel if set. Neither set, no remote type is passed to the cluster (which will probably result in an error as it won't know how to handle it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant