Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-wrap the FAQ to 80 character width #1157

Merged
merged 2 commits into from Apr 8, 2024
Merged

Re-wrap the FAQ to 80 character width #1157

merged 2 commits into from Apr 8, 2024

Conversation

atouchet
Copy link
Contributor

@atouchet atouchet commented Apr 8, 2024

No description provided.

@cuviper
Copy link
Member

cuviper commented Apr 8, 2024

What text width did you use? It looks rather narrow...

@atouchet
Copy link
Contributor Author

atouchet commented Apr 8, 2024

Those are 70 character widths which is what the Readme and the rest of the FAQ already appear to be using. This is just adjusting a few paragraphs to be consistent with those.

@cuviper
Copy link
Member

cuviper commented Apr 8, 2024

I think it may have been 72, which would still fit some of the existing lines here. But if we're going to rewrap, I'd prefer to go wider to 80.

@atouchet
Copy link
Contributor Author

atouchet commented Apr 8, 2024

I tried taking a look and I don't think the rest of the document matches 72 but regardless I could rewrap it to 80 if you would prefer that.

@cuviper
Copy link
Member

cuviper commented Apr 8, 2024

We haven't enforced anything, so I have no doubt that it's inconsistent. Yes, let's do 80 please.

@atouchet
Copy link
Contributor Author

atouchet commented Apr 8, 2024

Okay. Should the Readme be rewrapped too? It is also currently using 70.

@cuviper
Copy link
Member

cuviper commented Apr 8, 2024

Sure, if you're interested, go ahead in the readme too.

@atouchet
Copy link
Contributor Author

atouchet commented Apr 8, 2024

There ended up being more docs in this repo than I originally realized so I opted to just re-wrap the FAQ page to 80.

@atouchet atouchet changed the title Use consistent line lengths in FAQ Re-wrap the FAQ to 80 character width Apr 8, 2024
@cuviper
Copy link
Member

cuviper commented Apr 8, 2024

Thanks!

@cuviper cuviper added this pull request to the merge queue Apr 8, 2024
Merged via the queue into rayon-rs:main with commit 8ccfda3 Apr 8, 2024
4 checks passed
@atouchet atouchet deleted the faq branch April 9, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants